8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp

[MBaesken]

When building with clang on Linux ppc64le, we run into this warning as error :

/open_jdk/jdk_test/jdk/src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp:257:17: error: converting the result of '?:' with integer constants to a boolean always evaluates to 'true' [-Werror,-Wtautological-constant-compare]
else if ((sig == USE_POLL_BIT_ONLY ? SIGTRAP : SIGSEGV) &&
^
1 error generated.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18818/head:pull/18818
$ git checkout pull/18818

Update a local copy of the PR:
$ git checkout pull/18818
$ git pull https://git.openjdk.org/jdk.git pull/18818/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18818

View PR using the GUI difftool:
$ git pr show -t 18818

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18818.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330524: Linux ppc64le compile warning with clang  in os_linux_ppc.cpp

Reviewed-by: mdoerr, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
• ec180d4: 8324950: IGV: save the state to a file
• 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
• 5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
• b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
• 60b65e6: 8325872: Make GuaranteedSafepointInterval default 0
• b049609: 8330094: RISC-V: Save and restore FRM in the call stub
• 4b55fe5: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
• 5eb2c59: 8330475: Remove unused default value for ModRefBarrierSet::write_ref_array_pre
• 003e86f: 8324755: Enable parallelism in vmTestbase/gc/gctests/LargeObjects tests
• ... and 6 more: https://git.openjdk.org/jdk/compare/192ec387bc074b25465decf598a4dd87651cbcbb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (095c5320)

[TheRealMDoerr]

Thanks for fixing it! The current code is wrong and only works because the succeeding checks are strong enough.

[MBaesken]

Hi Christoph and Martin, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 252c62a.
Since your change was applied there have been 19 commits pushed to the master branch:

• 32946e1: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
• 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class
• 235ba9a: 8330458: Add missing @SInCE tag to ClassFile.JAVA_23_VERSION
• f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
• ec180d4: 8324950: IGV: save the state to a file
• 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
• 5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
• b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
• 60b65e6: 8325872: Make GuaranteedSafepointInterval default 0
• b049609: 8330094: RISC-V: Save and restore FRM in the call stub
• ... and 9 more: https://git.openjdk.org/jdk/compare/192ec387bc074b25465decf598a4dd87651cbcbb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 252c62a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.