8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

[gerard-ziemski]

This is a 3rd attempt of the same fix:

1st one had to be pulled out because of a bug in zsh
2nd one had a workaround for the bug in zsh, but then uncovered an issue in JWDP (JDK-8324668), which was subsequently fixed.

Tested with MACH5 tier1-9 with no unique or new failures on macOS

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE (Enhancement - P4)

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer) ⚠️ Review applies to 1376278e
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 1376278e

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18821/head:pull/18821
$ git checkout pull/18821

Update a local copy of the PR:
$ git checkout pull/18821
$ git pull https://git.openjdk.org/jdk.git pull/18821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18821

View PR using the GUI difftool:
$ git pr show -t 18821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18821.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gerard-ziemski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324577: [REDO] - [IMPROVE] OPEN_MAX is no longer the max limit on macOS >= 10.6 for RLIMIT_NOFILE

Reviewed-by: dcubed, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 0b9350e: 8322992: Javac fails with StackOverflowError when compiling deeply nested synchronized blocks
• 20be5e0: 8314846: Do not store Klass::_secondary_super_cache in CDS archive
• 7e421ce: 8330585: Refactor/rename forwardee handling
• 3e65d90: 8330820: Remove remnants of operator_new.cpp in build system
• 936a47d: 8330607: Deprecate -XX:+UseEmptySlotsInSupers
• ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups
• 3e185c7: 8330154: Serial: Remove TenuredSpace::update_for_block
• f889797: 8330463: Rename invalidate() to write_region() in ModRefBarrierSet
• c4f5c51: 8330576: ZYoungCompactionLimit should have range check
• 70acade: 8330339: G1: Move some public methods to private in G1BlockOffsetTable APIs
• ... and 39 more: https://git.openjdk.org/jdk/compare/fd331ff17330329a656181cb58714f1bd1623fcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@gerard-ziemski
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (6502f845)
• 00: Full (1376278e)

[dcubed-ojdk]

I compared this patch to the previous patch (8300088) and it is the
same in the core part of the fix. All but one of the editorial changes
from 8300088 have been dropped which is good for a backport.

It would be good if you revived all of the editorial fixes from 8300088
and integrated them into the main line using a separate RFE.

Thanks for documenting your testing.

[dholmes-ora]

LGTM2

Thanks

[gerard-ziemski]

@dcubed-ojdk @dholmes-ora re-requested reviews.

For such a trivial change (1 letter from capital to small in a comment) not sure we need it, but it's a protocol, so I'm going to wait for your re-reviews.

Thanks!

[gerard-ziemski]

/integrate

[openjdk]

Going to push as commit f1d0e71.
Since your change was applied there have been 93 commits pushed to the master branch:

• 74b11cc: 8331004: Serial: Remove unused GenClosure
• 45ed97f: 8330464: hserr generic events - add entry for the before_exit calls
• e311ba3: 8330626: ZGC: Windows address space placeholders not managed correctly
• e923dfe: 8314592: Add shortcut to SymbolLookup::find
• 1519081: 8330303: Crash: assert(_target_jt == nullptr || _target_jt->vthread() == target_h()) failed
• 2bb5cf5: 8330155: Serial: Remove TenuredSpace
• 7bb59dc: 8330670: Obsolete ScavengeBeforeFullGC
• 174d626: 8328741: serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java failed with unexpected owner
• e681e9b: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
• c439c8c: 8323429: Missing C2 optimization for FP min/max when both inputs are same
• ... and 83 more: https://git.openjdk.org/jdk/compare/fd331ff17330329a656181cb58714f1bd1623fcb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gerard-ziemski Pushed as commit f1d0e71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.