Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311098: Change comment in verificationType.hpp to refer to _sym #18830

Closed

Conversation

iklam
Copy link
Member

@iklam iklam commented Apr 17, 2024

Please review this trivial comment change.

The related code was changed during PermGen removal. Symbols used to be oops. Now they are metaspace objects.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311098: Change comment in verificationType.hpp to refer to _sym (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18830/head:pull/18830
$ git checkout pull/18830

Update a local copy of the PR:
$ git checkout pull/18830
$ git pull https://git.openjdk.org/jdk.git pull/18830/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18830

View PR using the GUI difftool:
$ git pr show -t 18830

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18830.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2024

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2024

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311098: Change comment in verificationType.hpp to refer to _sym

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 17, 2024
@openjdk
Copy link

openjdk bot commented Apr 17, 2024

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 17, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2024

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2024
@iklam
Copy link
Member Author

iklam commented Apr 18, 2024

Thanks @calvinccheung for the review
/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

Going to push as commit fe0227e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2024
@openjdk openjdk bot closed this Apr 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@iklam Pushed as commit fe0227e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants