Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330569: Rename Nix to Posix in platform-dependent attachListener code #18836

Closed
wants to merge 1 commit into from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Apr 18, 2024

Hi,

Revert the rename performed in 8324683.

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8330569: Rename Nix to Posix in platform-dependent attachListener code (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18836/head:pull/18836
$ git checkout pull/18836

Update a local copy of the PR:
$ git checkout pull/18836
$ git pull https://git.openjdk.org/jdk.git pull/18836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18836

View PR using the GUI difftool:
$ git pr show -t 18836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18836.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330569: Rename Nix to Posix in platform-dependent attachListener code

Reviewed-by: mdoerr, stuefe, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class
  • 235ba9a: 8330458: Add missing @SInCE tag to ClassFile.JAVA_23_VERSION
  • f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
  • ec180d4: 8324950: IGV: save the state to a file
  • 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
  • 5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
  • b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
  • 60b65e6: 8325872: Make GuaranteedSafepointInterval default 0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8330569 8330569: Rename Nix to Posix in platform-dependent attachListener code Apr 18, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 18, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the long term, I'd prefer to switch to _unix as suggested by #18283 (comment)

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2024
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

I prefer Posix to Unix.

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jdksjolen
Copy link
Contributor Author

Thanks.

/merge

@jdksjolen
Copy link
Contributor Author

/integrate

Of course.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@jdksjolen Unknown command merge - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented Apr 19, 2024

Going to push as commit 177092b.
Since your change was applied there have been 15 commits pushed to the master branch:

  • eb60822: 8310072: JComboBox/DisabledComboBoxFontTestAuto: Enabled and disabled ComboBox does not match in these LAFs: GTK+
  • 85261bc: 8330266: RISC-V: Restore frm to RoundingMode::rne after JNI
  • 9f2a4fa: 8330572: jdk.internal.net.http.HttpConnection calls an expensive checkOpen() when returning a HTTP/1.1 connection to the pool
  • 8990864: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
  • 46a2ce4: 8330063: Upgrade jQuery to 3.7.1
  • 252c62a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
  • 32946e1: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
  • 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class
  • 235ba9a: 8330458: Add missing @SInCE tag to ClassFile.JAVA_23_VERSION
  • f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
  • ... and 5 more: https://git.openjdk.org/jdk/compare/b0496096dc8d7dc7acf28aa006141a3ecea446de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2024
@openjdk openjdk bot closed this Apr 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2024
@openjdk
Copy link

openjdk bot commented Apr 19, 2024

@jdksjolen Pushed as commit 177092b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants