8330266: RISC-V: Restore frm to RoundingMode::rne after JNI

[Hamlin-Li]

Hi,
Can you help to review this patch?
It's exactly the same as #18785 which is withdrawn, the reason could be that I deleted the branch restore-frm-after-jni after I /integrate the pr, but in fact the deletion happened before it's indeed integrated by github, so it caused the withdraw.
Sorry for the inconvenience.

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330266: RISC-V: Restore frm to RoundingMode::rne after JNI (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Robbin Ehn (@robehn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18839/head:pull/18839
$ git checkout pull/18839

Update a local copy of the PR:
$ git checkout pull/18839
$ git pull https://git.openjdk.org/jdk.git pull/18839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18839

View PR using the GUI difftool:
$ git pr show -t 18839

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18839.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330266: RISC-V: Restore frm to RoundingMode::rne after JNI

Reviewed-by: fyang, rehn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

• 32946e1: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
• 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class
• 235ba9a: 8330458: Add missing @SInCE tag to ClassFile.JAVA_23_VERSION
• f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
• ec180d4: 8324950: IGV: save the state to a file
• 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
• 5853a2c: 8330533: JFR: LocalDateTime should not use milliseconds since epoch
• b648ed0: 8329997: Add provisions for checking memory segment alignment constraints
• 60b65e6: 8325872: Make GuaranteedSafepointInterval default 0
• b049609: 8330094: RISC-V: Save and restore FRM in the call stub
• ... and 96 more: https://git.openjdk.org/jdk/compare/7df492627b933f48750985c26de69be3f86115cb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (68964755)

[Hamlin-Li]

Thanks @RealFYang for your quick review!

/integrate

[robehn]

Thanks!

But the flag RestoreMXCSROnJNICalls is actually "x86 specific".
We should add a new flag that alias this, such as "RestoreFPModeOnJNICalls". Or whatever is good generic name.

[Hamlin-Li]

In fact, RestoreMXCSROnJNICalls also used on aarch64.
I agree it's not a good name, I think it's better to have a uniform name across platforms, so maybe we should modify the name together in another pr after this pr?

[robehn]

In fact, RestoreMXCSROnJNICalls also used on aarch64. I agree it's not a good name, I think it's better to have a uniform name across platforms, so maybe we should modify the name together in another pr after this pr?

Yes, I know. Andrew pointed that out in aarch64 PR.

Yes, we should add a new flag aliasing the old flag. (see argument.cpp)
Then start the processes of deprecating the old flag.

[Hamlin-Li]

OK, I created https://bugs.openjdk.org/browse/JDK-8330634 to track RestoreMXCSROnJNICalls renaming

[Hamlin-Li]

OK, I created https://bugs.openjdk.org/browse/JDK-8330634 to track RestoreMXCSROnJNICalls renaming

Oh, I found https://bugs.openjdk.org/browse/JDK-8321535 is already created, and I think Andrew will work on it. Maybe I should close https://bugs.openjdk.org/browse/JDK-8330634 as duplicate.

[openjdk]

Going to push as commit 85261bc.
Since your change was applied there have been 110 commits pushed to the master branch:

• 9f2a4fa: 8330572: jdk.internal.net.http.HttpConnection calls an expensive checkOpen() when returning a HTTP/1.1 connection to the pool
• 8990864: 8330156: RISC-V: Range check auipc + signed 12 imm instruction
• 46a2ce4: 8330063: Upgrade jQuery to 3.7.1
• 252c62a: 8330524: Linux ppc64le compile warning with clang in os_linux_ppc.cpp
• 32946e1: 8295111: dpkg appears to have problems resolving symbolically linked native libraries
• 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class
• 235ba9a: 8330458: Add missing @SInCE tag to ClassFile.JAVA_23_VERSION
• f713766: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
• ec180d4: 8324950: IGV: save the state to a file
• 571e6bc: 8330419: Unused code in ConnectionGraph::specialize_castpp
• ... and 100 more: https://git.openjdk.org/jdk/compare/7df492627b933f48750985c26de69be3f86115cb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 85261bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.