Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258911: ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java on Linux-X64 #1884

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 23, 2020

This is a trivial fix to ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java
on Linux-X64.

The test has been failing fairly frequently in the JDK17 CI when it is run with the
"-XX:NativeMemoryTracking=detail" option. We currently only specify that configuration
on linux-x64 so I'm going to ProblemList the test only on Linux-X64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258911: ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java on Linux-X64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1884/head:pull/1884
$ git checkout pull/1884

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2020

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label add serviceability-dev hotspot-runtime

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org labels Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk
The serviceability label was successfully added.

The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 23, 2020 20:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2020
@alexmenkov
Copy link

Agreed that this is trivial fix

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258911: ProblemList serviceability/attach/RemovingUnixDomainSocketTest.java on Linux-X64

Reviewed-by: amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2020
@dcubed-ojdk
Copy link
Member Author

@alexmenkov - Thanks for the fast review!

/integrate

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2020

Webrevs

@openjdk openjdk bot closed this Dec 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2020
@dcubed-ojdk dcubed-ojdk deleted the JDK-8258911 branch December 23, 2020 20:30
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk Pushed as commit e46edb5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants