8295111: dpkg appears to have problems resolving symbolically linked native libraries

[alexeysemenyukoracle]

Pass a path with resolved symlinks to dpkg -S command. If it fails, try the original path if they differ.

Testing on Ubuntu 24.04 passed. Successfully created a .deb package from SwingSet2.jar with the not-empty list of dependencies. Before the fix the list of required packages was empty. In jpackage log:

[19:30:48.784] Running dpkg
[19:30:49.118] Command [PID: 244104]:
    dpkg -S /usr/lib/x86_64-linux-gnu/libm.so.6
[19:30:49.118] Output:
    libc6:amd64: /usr/lib/x86_64-linux-gnu/libm.so.6
[19:30:49.118] Returned: 0

[19:30:49.118] /lib/x86_64-linux-gnu/libm.so.6 is provided by [libc6]

It was looking for a package providing "/lib/x86_64-linux-gnu/libm.so.6" library, but the actual argument to "dpgk -S" command was "/usr/lib/x86_64-linux-gnu/libm.so.6".

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295111: dpkg appears to have problems resolving symbolically linked native libraries (Bug - P2)

Reviewers

• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18844/head:pull/18844
$ git checkout pull/18844

Update a local copy of the PR:
$ git checkout pull/18844
$ git pull https://git.openjdk.org/jdk.git pull/18844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18844

View PR using the GUI difftool:
$ git pr show -t 18844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18844.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295111: dpkg appears to have problems resolving symbolically linked native libraries

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexeysemenyukoracle]

@sashamatveev please review

[mlbridge]

Webrevs

• 00: Full (9711ab37)

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit 32946e1.
Since your change was applied there has been 1 commit pushed to the master branch:

• 6ee8407: 8324342: Doclet should default @SInCE for a nested class to that of its enclosing class

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit 32946e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Mailing list message from Michael Hall on core-libs-dev:

I don?t know what flavors you are looking to support but there seems to be somewhat different issues on a Raspberry Pi. I was just trying to use jpackage there.

I am getting errors like the command

dpkg -S /lib/aarch64-linux-gnu/libXau.so <http://libxau.so/>.6
The file isn?t found

These actually appear to have entries in

/usr/lib/aarch64-linux-gnu

Which in turn appear to be symbolic links like?

/usr/lib/aarch64-linux-gnu/libXau.so <http://libxau.so/>.6 -> libXau.so <http://libxau.so/>.6.0.0

I am thinking I could try making symbolic links as a workaround myself.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20240419/9a54a55a/attachment.htm>

[mlbridge]

Mailing list message from Michael Hall on core-libs-dev:

I was apparently at least partly misunderstanding this. I thought I verified a missing file on one exception trace. I installed what appeared to be missing packages and that one no longer shows up.

I still get exception traces on some .so files which appear to be reporting errors on dpkg -S commands unable to determine the packages for some files. The files are in fact there. I was seeing these because I was running verbose. Trying some old stuff I still have to see if I could get jpackage to work. Without verbose it runs through indicating no errors. However, running the created deb file doesn?t appear to be creating an app that I can find. Nothing else seems to give me any information on what the actual install is doing. I did notice in the verbose output a lot of libjvm.so <http://libjvm.so/> is missing messages.

Anyhow, for my current purposes the code doesn?t have to run as a Pi application. I can command line if I have to. Or I was thinking about modifying some of the application code to run standalone.

Thanks anyhow,

Mike

On Apr 19, 2024, at 1:13?PM, Michael Hall <mik3hall at gmail.com> wrote:

I don?t know what flavors you are looking to support but there seems to be somewhat different issues on a Raspberry Pi. I was just trying to use jpackage there.

I am getting errors like the command

dpkg -S /lib/aarch64-linux-gnu/libXau.so <http://libxau.so/>.6
The file isn?t found

These actually appear to have entries in

/usr/lib/aarch64-linux-gnu

Which in turn appear to be symbolic links like?

/usr/lib/aarch64-linux-gnu/libXau.so <http://libxau.so/>.6 -> libXau.so <http://libxau.so/>.6.0.0

I am thinking I could try making symbolic links as a workaround myself.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/core-libs-dev/attachments/20240419/b1c83ce5/attachment.htm>