8330578: The VM creates instance of abstract class VirtualMachineError

[coleenp]

It's a bug that the VM creates an instance of the abstract class VirtualMachineError. In the cases where we throw VME, we should throw OOM or StackOverflowError instead.

Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330578: The VM creates instance of abstract class VirtualMachineError (Bug - P4)

Reviewers

• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to a70dc567
• Dean Long (@dean-long - Reviewer) ⚠️ Review applies to 8bf59f98
• Julian Waters (@TheShermanTanker - Committer) ⚠️ Review applies to 8bf59f98
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18847/head:pull/18847
$ git checkout pull/18847

Update a local copy of the PR:
$ git checkout pull/18847
$ git pull https://git.openjdk.org/jdk.git pull/18847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18847

View PR using the GUI difftool:
$ git pr show -t 18847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18847.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330578: The VM creates instance of abstract class VirtualMachineError

Reviewed-by: iklam, dlong, jwaters, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 8961077: 8309259: Reduce calls to MethodHandles.lookup() in jdk.internal.net.http.Stream
• 574ba14: 8330862: GCBarrierIRExample fails when a different GC is selected via the command line
• 550a138: 8306928: Duplicate variable assignement in jdk.internal.net.http.AuthenticationFilter#getCredentials
• 57ebd04: 8330153: C2: dump barrier information for all Mach nodes
• 58ad399: 8330821: Rename UnsafeCopyMemory
• 1d52234: 8330704: Clean up non-standard use of /** comments in some langtools tests
• 83c74d7: 8329717: Missing @since tags in elements in DocumentationTool and Taglet
• 0b9350e: 8322992: Javac fails with StackOverflowError when compiling deeply nested synchronized blocks
• 20be5e0: 8314846: Do not store Klass::_secondary_super_cache in CDS archive
• 7e421ce: 8330585: Refactor/rename forwardee handling
• ... and 20 more: https://git.openjdk.org/jdk/compare/3c1d1d93d7b1de229753ed697f008bd5639ac957...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 07: Full - Incremental (0f6c27fc)
• 06: Full - Incremental (a70dc567)
• 05: Full - Incremental (e4e1f8d3)
• 04: Full (43805500)
• 03: Full - Incremental (cb61e8a5)
• 02: Full - Incremental (9eaf7956)
• 01: Full - Incremental (92e4f015)
• 00: Full (8bf59f98)

[iklam]

LGTM

[TheShermanTanker]

Looks good!

[dholmes-ora]

There are a couple of uses of NPE that may be better handled by InternalError - so you could just replace the _virtual_machine_error bits with _internal_error instead.

Thanks.

[dholmes-ora]

Looks good! Thanks for making the updates to use InternalError!

[coleenp]

Thanks for the reviews and comments Ioi, David, Dean, Julian and Doug.
/integrate

[openjdk]

Going to push as commit fcb4a8b.
Since your change was applied there have been 35 commits pushed to the master branch:

• 3bd6982: 8326150: Typo in the documentation for jdk.jshell
• d9d926d: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs
• 1a6da3d: 8330822: Remove ModRefBarrierSet::write_ref_array_work
• 281f9bd: 8330735: RISC-V: No need to move sp to tmp register in set_last_Java_frame
• daa5a4b: 8330802: Desugar switch in Locale::createLocale
• 8961077: 8309259: Reduce calls to MethodHandles.lookup() in jdk.internal.net.http.Stream
• 574ba14: 8330862: GCBarrierIRExample fails when a different GC is selected via the command line
• 550a138: 8306928: Duplicate variable assignement in jdk.internal.net.http.AuthenticationFilter#getCredentials
• 57ebd04: 8330153: C2: dump barrier information for all Mach nodes
• 58ad399: 8330821: Rename UnsafeCopyMemory
• ... and 25 more: https://git.openjdk.org/jdk/compare/3c1d1d93d7b1de229753ed697f008bd5639ac957...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit fcb4a8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.