Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258913: ProblemList javax/swing/JComboBox/6559152/bug6559152.java on Linux-X64 #1885

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Dec 23, 2020

A trivial fix to ProblemList javax/swing/JComboBox/6559152/bug6559152.java on Linux-X64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258913: ProblemList javax/swing/JComboBox/6559152/bug6559152.java on Linux-X64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1885/head:pull/1885
$ git checkout pull/1885

@dcubed-ojdk
Copy link
Member Author

/label add client

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2020

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk The label client is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@dcubed-ojdk
Copy link
Member Author

/label add swing

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk
The swing label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review December 23, 2020 22:23
@dcubed-ojdk
Copy link
Member Author

@prrace - please review when you get the chance.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258913: ProblemList javax/swing/JComboBox/6559152/bug6559152.java on Linux-X64

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • cdb487a: 8258856: VM build without C1/C2 fails after JDK-8243205
  • 78c9fb9: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2020
@dcubed-ojdk
Copy link
Member Author

@prrace - Thanks for the fast review.

/integrate

@openjdk openjdk bot closed this Dec 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 23, 2020
@openjdk
Copy link

openjdk bot commented Dec 23, 2020

@dcubed-ojdk Since your change was applied there have been 2 commits pushed to the master branch:

  • cdb487a: 8258856: VM build without C1/C2 fails after JDK-8243205
  • 78c9fb9: 8258851: Mismatch in SunPKCS11 provider registration properties and actual implementation

Your commit was automatically rebased without conflicts.

Pushed as commit 127582f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8258913 branch December 23, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
2 participants