-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize #18877
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 43 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@zhengyu123 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8272364
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
Can the example in the bug-report be turned into a jtreg test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
/integrate Thanks for the review, @rkennke @albertnetymk |
Going to push as commit 6bef047.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 6bef047. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk22u |
@zhengyu123 the backport was successfully created on the branch backport-zhengyu123-6bef0474 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:
|
This appears to be another miscalculation of gc ergonomics. When
NewSize
is not explicitly set,MinNewSize
should be derived fromMinHeapSize
usingNewRatio
.This pull request has dependency on PR#18539
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18877/head:pull/18877
$ git checkout pull/18877
Update a local copy of the PR:
$ git checkout pull/18877
$ git pull https://git.openjdk.org/jdk.git pull/18877/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18877
View PR using the GUI difftool:
$ git pr show -t 18877
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18877.diff
Webrev
Link to Webrev Comment