Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize #18877

Closed
wants to merge 16 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 20, 2024

This appears to be another miscalculation of gc ergonomics. When NewSize is not explicitly set, MinNewSize should be derived from MinHeapSize using NewRatio.

This pull request has dependency on PR#18539


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18877/head:pull/18877
$ git checkout pull/18877

Update a local copy of the PR:
$ git checkout pull/18877
$ git pull https://git.openjdk.org/jdk.git pull/18877/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18877

View PR using the GUI difftool:
$ git pr show -t 18877

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18877.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2024

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into pr/18539 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 20, 2024

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize

Reviewed-by: ayang, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 20, 2024

@zhengyu123 The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 20, 2024
@zhengyu123 zhengyu123 marked this pull request as ready for review April 20, 2024 16:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 20, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2024

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/18539 to master April 30, 2024 16:23
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8272364
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Apr 30, 2024

⚠️ @zhengyu123 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@rkennke
Copy link
Contributor

rkennke commented May 2, 2024

Can the example in the bug-report be turned into a jtreg test?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2024
Copy link
Contributor

@rkennke rkennke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@zhengyu123
Copy link
Contributor Author

/integrate

Thanks for the review, @rkennke @albertnetymk

@openjdk
Copy link

openjdk bot commented May 3, 2024

Going to push as commit 6bef047.
Since your change was applied there have been 47 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 3, 2024
@openjdk openjdk bot closed this May 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

@zhengyu123 Pushed as commit 6bef047.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123
Copy link
Contributor Author

/backport jdk22u

@openjdk
Copy link

openjdk bot commented May 17, 2024

@zhengyu123 the backport was successfully created on the branch backport-zhengyu123-6bef0474 in my personal fork of openjdk/jdk22u. To create a pull request with this backport targeting openjdk/jdk22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6bef0474 from the openjdk/jdk repository.

The commit being backported was authored by Zhengyu Gu on 3 May 2024 and was reviewed by Albert Mingkun Yang and Roman Kennke.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk22u:

$ git fetch https://github.com/openjdk-bots/jdk22u.git backport-zhengyu123-6bef0474:backport-zhengyu123-6bef0474
$ git checkout backport-zhengyu123-6bef0474
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk22u.git backport-zhengyu123-6bef0474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants