8330362: G1: Inline offset array element accessor in G1BlockOffsetTable

[lgxbslgx]

Hi all,

This patch inlines the method G1BlockOffsetTable::set_offset_array_raw. I think the method G1BlockOffsetTable::offset_array is a getter corresponding to the setter G1BlockOffsetTable::set_offset_array and the check in G1BlockOffsetTable::offset_array is useful, so it seems good to keep it.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330362: G1: Inline offset array element accessor in G1BlockOffsetTable (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18881/head:pull/18881
$ git checkout pull/18881

Update a local copy of the PR:
$ git checkout pull/18881
$ git pull https://git.openjdk.org/jdk.git pull/18881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18881

View PR using the GUI difftool:
$ git pr show -t 18881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18881.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330362: G1: Inline offset array element accessor in G1BlockOffsetTable

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 281f9bd: 8330735: RISC-V: No need to move sp to tmp register in set_last_Java_frame
• daa5a4b: 8330802: Desugar switch in Locale::createLocale
• 8961077: 8309259: Reduce calls to MethodHandles.lookup() in jdk.internal.net.http.Stream
• 574ba14: 8330862: GCBarrierIRExample fails when a different GC is selected via the command line
• 550a138: 8306928: Duplicate variable assignement in jdk.internal.net.http.AuthenticationFilter#getCredentials
• 57ebd04: 8330153: C2: dump barrier information for all Mach nodes
• 58ad399: 8330821: Rename UnsafeCopyMemory
• 1d52234: 8330704: Clean up non-standard use of /** comments in some langtools tests
• 83c74d7: 8329717: Missing @since tags in elements in DocumentationTool and Taglet
• 0b9350e: 8322992: Javac fails with StackOverflowError when compiling deeply nested synchronized blocks
• ... and 7 more: https://git.openjdk.org/jdk/compare/c4f5c5140a85818152c6e17414a36deabe491f7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2470a102)

[albertnetymk]

the check in G1BlockOffsetTable::offset_array is useful

I feel its value is limited, if update_for_block and related public apis have already asserted address is within the reserved heap.

[lgxbslgx]

the check in G1BlockOffsetTable::offset_array is useful

I feel its value is limited, if update_for_block and related public apis have already asserted address is within the reserved heap.

Many places(about 20) use the offset_array. Can't confirm whether it is good to remove offset_array now. Should I integrate this patch without removing offset_array?

[albertnetymk]

Should I integrate this patch without removing offset_array?

Sure.

[lgxbslgx]

Thanks for your reviews. Integrating.

/integrate

[openjdk]

Going to push as commit b07e153.
Since your change was applied there have been 27 commits pushed to the master branch:

• b6518a5: 8329417: Remove objects with no pointers from relocation bitmap
• 383fe6e: 8330388: Remove invokedynamic cache index encoding
• 2ea8926: 8330961: Remove redundant public specifier in ModRefBarrierSet
• 3d5eeac: 8289770: Remove Windows version macro from ShellFolder2.cpp
• 6158da5: 8330108: Increase CipherInputStream buffer size
• a92ad03: 8329995: Restricted access to /proc can cause JFR initialization to crash
• fcb4a8b: 8330578: The VM creates instance of abstract class VirtualMachineError
• 3bd6982: 8326150: Typo in the documentation for jdk.jshell
• d9d926d: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs
• 1a6da3d: 8330822: Remove ModRefBarrierSet::write_ref_array_work
• ... and 17 more: https://git.openjdk.org/jdk/compare/c4f5c5140a85818152c6e17414a36deabe491f7b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit b07e153.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.