8330813: Don't call methods from Compressed(Oops|Klass) if the associated mode is inactive

[tstuefe]

We should not call methods from CompressedOops if we run with -XX:-UseCompressedOops, and the same goes for CompressedKlass and -XX:-UseCompressedClassPointers. (the latter we do assert in Lilliput).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330813: Don't call methods from Compressed(Oops|Klass) if the associated mode is inactive (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Ashutosh Mehra (@ashu-mehra - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18883/head:pull/18883
$ git checkout pull/18883

Update a local copy of the PR:
$ git checkout pull/18883
$ git pull https://git.openjdk.org/jdk.git pull/18883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18883

View PR using the GUI difftool:
$ git pr show -t 18883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18883.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330813: Don't call methods from Compressed(Oops|Klass) if the associated mode is inactive

Reviewed-by: stefank, asmehra

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 184 new commits pushed to the master branch:

• a024eed: 8331478: JFR: Rename printHelp methods for jdk.jfr.internal.dcmd classes
• 9912abf: 8331011: [XWayland] TokenStorage fails under Security Manager
• 257a07d: 8331511: Tests should not use the "Classpath" exception form of the legal header
• c21672d: 8331077: nroff man page update for jar tool
• cccc953: 8329258: TailCall should not use frame pointer register for jump target
• 4a78906: 8331537: Test code should not use the "Classpath" exception clause
• 2056968: 8331513: Tests should not use the "Classpath" exception form of the legal header
• c9255f3: 8331514: Tests should not use the "Classpath" exception form of the legal header
• beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
• ae82405: 8323058: Revisit j.l.classfile.CodeBuilder API surface
• ... and 174 more: https://git.openjdk.org/jdk/compare/32946e1882e9b22c983cbba3c6bda3cc7295946a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tstuefe The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (95f764bb)

[stefank]

Looks good to me.

[tstuefe]

@rkennke? Its trivial

[ashu-mehra]

lgtm

[tstuefe]

Thanks @ashu-mehra

/integrate

[openjdk]

Going to push as commit dd0b641.
Since your change was applied there have been 185 commits pushed to the master branch:

• 389f6fe: 8331344: No compiler replay file with CompilerCommand MemLimit
• a024eed: 8331478: JFR: Rename printHelp methods for jdk.jfr.internal.dcmd classes
• 9912abf: 8331011: [XWayland] TokenStorage fails under Security Manager
• 257a07d: 8331511: Tests should not use the "Classpath" exception form of the legal header
• c21672d: 8331077: nroff man page update for jar tool
• cccc953: 8329258: TailCall should not use frame pointer register for jump target
• 4a78906: 8331537: Test code should not use the "Classpath" exception clause
• 2056968: 8331513: Tests should not use the "Classpath" exception form of the legal header
• c9255f3: 8331514: Tests should not use the "Classpath" exception form of the legal header
• beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
• ... and 175 more: https://git.openjdk.org/jdk/compare/32946e1882e9b22c983cbba3c6bda3cc7295946a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit dd0b641.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.