8330815: Use pattern matching for instanceof in KeepAliveCache

[RealCLanger]

In su.net.www.http.KeepAliveCache we could use pattern matching for instanceof.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330815: Use pattern matching for instanceof in KeepAliveCache (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) ⚠️ Review applies to a7129acd
• Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18885/head:pull/18885
$ git checkout pull/18885

Update a local copy of the PR:
$ git checkout pull/18885
$ git pull https://git.openjdk.org/jdk.git pull/18885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18885

View PR using the GUI difftool:
$ git pr show -t 18885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18885.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330815: Use pattern matching for instanceof in KeepAliveCache

Reviewed-by: jpai, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 3bd6982: 8326150: Typo in the documentation for jdk.jshell
• d9d926d: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs
• 1a6da3d: 8330822: Remove ModRefBarrierSet::write_ref_array_work
• 281f9bd: 8330735: RISC-V: No need to move sp to tmp register in set_last_Java_frame
• daa5a4b: 8330802: Desugar switch in Locale::createLocale
• 8961077: 8309259: Reduce calls to MethodHandles.lookup() in jdk.internal.net.http.Stream
• 574ba14: 8330862: GCBarrierIRExample fails when a different GC is selected via the command line
• 550a138: 8306928: Duplicate variable assignement in jdk.internal.net.http.AuthenticationFilter#getCredentials
• 57ebd04: 8330153: C2: dump barrier information for all Mach nodes
• 58ad399: 8330821: Rename UnsafeCopyMemory
• ... and 8 more: https://git.openjdk.org/jdk/compare/3e185c70feef3febf75c58a5d4d394a4b772105f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (5c9f5cc9)
• 00: Full (a7129acd)

[jaikiran]

Hello Christoph, this cleanup change looks good to me.

[djelinski]

I'd prefer this instead:

        if (!(obj instanceof KeepAliveKey kae))
            return false;

because it's more awesome :) but what you propose looks good too.

[RealCLanger]

I'd prefer this instead:

        if (!(obj instanceof KeepAliveKey kae))
            return false;

because it's more awesome :) but what you propose looks good too.

Yes, you're right. Adapted. 😄

[RealCLanger]

/integrate

[openjdk]

Going to push as commit e818ab6.
Since your change was applied there have been 61 commits pushed to the master branch:

• d43654e: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp
• 21480a7: 8322135: Printing JTable in Windows L&F throws InternalError: HTHEME is null
• e6118ce: 8331018: Clean up non-standard use of /** comments in jdk.jshell
• a44ac02: 8330853: Add missing checks for ConnectionGraph::can_reduce_cmp() call
• 8a8d928: 8330611: AES-CTR vector intrinsic may read out of bounds (x86_64, AVX-512)
• 0014e0e: 8331061: Serial: Missed BOT update in TenuredGeneration::expand_and_allocate
• ea3909a: 8331054: C2 MergeStores: assert failed: unexpected basic type after JDK-8318446 and JDK-8329555
• 7b2560b: 8330849: Add test to verify memory usage with recursive locking
• 25871af: 8328896: Fontmetrics for large Fonts has zero width
• 1d06170: 8300148: Consider using a StoreStore barrier instead of Release barrier on ctor exit
• ... and 51 more: https://git.openjdk.org/jdk/compare/3e185c70feef3febf75c58a5d4d394a4b772105f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit e818ab6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.