Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330820: Remove remnants of operator_new.cpp in build system #18886

Closed

Conversation

magicus
Copy link
Member

@magicus magicus commented Apr 22, 2024

In JDK-8282469, the file operator_new.cpp was removed from Hotspot. Unfortunately, some ugly hacks related to this file remained in the build system. They should be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8330820: Remove remnants of operator_new.cpp in build system (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18886/head:pull/18886
$ git checkout pull/18886

Update a local copy of the PR:
$ git checkout pull/18886
$ git pull https://git.openjdk.org/jdk.git pull/18886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18886

View PR using the GUI difftool:
$ git pr show -t 18886

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18886.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2024

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330820: Remove remnants of operator_new.cpp in build system

Reviewed-by: tbell

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 936a47d: 8330607: Deprecate -XX:+UseEmptySlotsInSupers
  • ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 22, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2024

Webrevs

@magicus
Copy link
Member Author

magicus commented Apr 22, 2024

/integrate auto

@openjdk openjdk bot added the auto label Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@magicus This pull request will be automatically integrated when it is ready

Copy link
Member

@tbell29552 tbell29552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

Going to push as commit 3e65d90.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 936a47d: 8330607: Deprecate -XX:+UseEmptySlotsInSupers
  • ee7b2e9: 8330051: Small ObjectMonitor spinning code cleanups

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 22, 2024
@openjdk openjdk bot closed this Apr 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 22, 2024
@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@openjdk[bot] Pushed as commit 3e65d90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the remove-operator_new-from-build branch April 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants