Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252311: AArch64: save two words in itable lookup stub #189

Closed

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Sep 15, 2020

The change was reviewed on hotspot-compiler-dev, but I missed the time to complete
the commit to the mercural repo. Can I get it approved once again?

Issue: JDK-8252311

Description:
The interface method lookup stub becomes hot when interface calls
are performed frequently. The stub assembly code can be made
shorter (132->124 bytes) by using a pre-increment instruction variant.

Review by Andrew Dinn && Andrew Haley:
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039818.html
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039833.html

For the reference, benchmark scores with higher iteration number:

Neoverse                              Cnt   Score     Error  ->    Score   Error   Units
InvokeInterface.bench                  25  6163.804 ±  5.116 -> 6303.035 ± 5.450  ops/ms
InvokeInterface.bench:L1-icache-loads   5   305.408 ±  1.895 ->  272.891 ± 0.750    #/op
InvokeInterface.bench:iTLB-loads        5   221.755 ±  0.990 ->  207.635 ± 0.566    #/op
InvokeInterface.bench:instructions      5  1035.468 ±  2.701 ->  953.466 ± 1.667    #/op 

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252311: AArch64: save two words in itable lookup stub

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/189/head:pull/189
$ git checkout pull/189

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@bulasevich The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 15, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@bulasevich This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252311: AArch64: save two words in itable lookup stub

Reviewed-by: adinn, aph
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 60 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 22f7af7fcff0d29d741483928d8540ebb6d10379.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@bulasevich
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Sep 19, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 19, 2020
@openjdk
Copy link

openjdk bot commented Sep 19, 2020

@bulasevich Since your change was applied there have been 60 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 224a30f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants