-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252311: AArch64: save two words in itable lookup stub #189
8252311: AArch64: save two words in itable lookup stub #189
Conversation
Reviewed-by: adinn, aph
👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into |
@bulasevich The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
@bulasevich This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 60 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@bulasevich Since your change was applied there have been 60 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 224a30f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The change was reviewed on hotspot-compiler-dev, but I missed the time to complete
the commit to the mercural repo. Can I get it approved once again?
Issue: JDK-8252311
Description:
The interface method lookup stub becomes hot when interface calls
are performed frequently. The stub assembly code can be made
shorter (132->124 bytes) by using a pre-increment instruction variant.
Review by Andrew Dinn && Andrew Haley:
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039818.html
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039833.html
For the reference, benchmark scores with higher iteration number:
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/189/head:pull/189
$ git checkout pull/189