Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327290: Remove unused notproduct option TraceInvocationCounterOverflow #18902

Closed
wants to merge 1 commit into from

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Apr 22, 2024

Hi all,

This PR removes the unused option TraceInvocationCounterOverflow. The only usage was removed in 8251462.

Testing:

  • Verified unrecognized option error is reported after removing option.

Thanks,
Sonia


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327290: Remove unused notproduct option TraceInvocationCounterOverflow (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18902/head:pull/18902
$ git checkout pull/18902

Update a local copy of the PR:
$ git checkout pull/18902
$ git pull https://git.openjdk.org/jdk.git pull/18902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18902

View PR using the GUI difftool:
$ git pr show -t 18902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18902.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327290: Remove unused notproduct option TraceInvocationCounterOverflow

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • b07e153: 8330362: G1: Inline offset array element accessor in G1BlockOffsetTable
  • b6518a5: 8329417: Remove objects with no pointers from relocation bitmap
  • 383fe6e: 8330388: Remove invokedynamic cache index encoding
  • 2ea8926: 8330961: Remove redundant public specifier in ModRefBarrierSet
  • 3d5eeac: 8289770: Remove Windows version macro from ShellFolder2.cpp
  • 6158da5: 8330108: Increase CipherInputStream buffer size
  • a92ad03: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • fcb4a8b: 8330578: The VM creates instance of abstract class VirtualMachineError
  • 3bd6982: 8326150: Typo in the documentation for jdk.jshell
  • d9d926d: 8330145: Serial: Refactor SerialHeap::scan_evacuated_objs
  • ... and 10 more: https://git.openjdk.org/jdk/compare/0b9350e8b619bc556f36652cde6f73211be5b85b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coleenp) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Apr 22, 2024

@SoniaZaldana The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 22, 2024
@SoniaZaldana SoniaZaldana marked this pull request as ready for review April 23, 2024 14:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the cleanup! This is trivial if you want to integrate today.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 23, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@SoniaZaldana
Your change (at version ea94dc2) is now ready to be sponsored by a Committer.

@coleenp
Copy link
Contributor

coleenp commented Apr 23, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

Going to push as commit 7157eea.
Since your change was applied there have been 22 commits pushed to the master branch:

  • b4cea70: 8330693: Generational ZGC: Simplify ZAddress::finalizable_good and ZAddress::mark_good
  • 412e306: 8329593: Drop adjustments to target parallelism when virtual threads do I/O on files opened for buffered I/O
  • b07e153: 8330362: G1: Inline offset array element accessor in G1BlockOffsetTable
  • b6518a5: 8329417: Remove objects with no pointers from relocation bitmap
  • 383fe6e: 8330388: Remove invokedynamic cache index encoding
  • 2ea8926: 8330961: Remove redundant public specifier in ModRefBarrierSet
  • 3d5eeac: 8289770: Remove Windows version macro from ShellFolder2.cpp
  • 6158da5: 8330108: Increase CipherInputStream buffer size
  • a92ad03: 8329995: Restricted access to /proc can cause JFR initialization to crash
  • fcb4a8b: 8330578: The VM creates instance of abstract class VirtualMachineError
  • ... and 12 more: https://git.openjdk.org/jdk/compare/0b9350e8b619bc556f36652cde6f73211be5b85b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 23, 2024
@openjdk openjdk bot closed this Apr 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@coleenp @SoniaZaldana Pushed as commit 7157eea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants