Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331004: Serial: Remove unused GenClosure #18922

Closed
wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Apr 23, 2024

Trivial removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331004: Serial: Remove unused GenClosure (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18922/head:pull/18922
$ git checkout pull/18922

Update a local copy of the PR:
$ git checkout pull/18922
$ git pull https://git.openjdk.org/jdk.git pull/18922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18922

View PR using the GUI difftool:
$ git pr show -t 18922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18922.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331004: Serial: Remove unused GenClosure

Reviewed-by: gli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 45ed97f: 8330464: hserr generic events - add entry for the before_exit calls
  • e311ba3: 8330626: ZGC: Windows address space placeholders not managed correctly
  • e923dfe: 8314592: Add shortcut to SymbolLookup::find
  • 1519081: 8330303: Crash: assert(_target_jt == nullptr || _target_jt->vthread() == target_h()) failed
  • 2bb5cf5: 8330155: Serial: Remove TenuredSpace
  • 7bb59dc: 8330670: Obsolete ScavengeBeforeFullGC
  • 174d626: 8328741: serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java failed with unexpected owner
  • e681e9b: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • c439c8c: 8323429: Missing C2 optimization for FP min/max when both inputs are same
  • 165ba87: 8330587: IGV: remove ControlFlowTopComponent
  • ... and 11 more: https://git.openjdk.org/jdk/compare/b4cea701c9cab15007c485088dd5b8d7025d83ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8331004 8331004: Serial: Remove unused GenClosure Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@albertnetymk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 23, 2024
@openjdk
Copy link

openjdk bot commented Apr 23, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 23, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 23, 2024

Webrevs

Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment preceding GenClosure, shown below, looks like a leftover of JDK-8234502 [1]. May be good to remove it?

  // The functions below are helper functions that a subclass of
  // "CollectedHeap" can use in the implementation of its virtual
  // functions.

[1] https://bugs.openjdk.org/browse/JDK-8234502

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 24, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

Going to push as commit 74b11cc.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 45ed97f: 8330464: hserr generic events - add entry for the before_exit calls
  • e311ba3: 8330626: ZGC: Windows address space placeholders not managed correctly
  • e923dfe: 8314592: Add shortcut to SymbolLookup::find
  • 1519081: 8330303: Crash: assert(_target_jt == nullptr || _target_jt->vthread() == target_h()) failed
  • 2bb5cf5: 8330155: Serial: Remove TenuredSpace
  • 7bb59dc: 8330670: Obsolete ScavengeBeforeFullGC
  • 174d626: 8328741: serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java failed with unexpected owner
  • e681e9b: 8330819: C2 SuperWord: bad dominance after pre-loop limit adjustment with base that has CastLL after pre-loop
  • c439c8c: 8323429: Missing C2 optimization for FP min/max when both inputs are same
  • 165ba87: 8330587: IGV: remove ControlFlowTopComponent
  • ... and 11 more: https://git.openjdk.org/jdk/compare/b4cea701c9cab15007c485088dd5b8d7025d83ef...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 24, 2024
@openjdk openjdk bot closed this Apr 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@albertnetymk Pushed as commit 74b11cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch April 24, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants