8330960: Serial: Remove SerialFullGC::_total_invocations

[lgxbslgx]

Hi all,

This patch removes the field SerialFullGC::_total_invocations and its related usages, and uses CollectedHeap::_total_full_collections instead.

Thanks for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330960: Serial: Remove SerialFullGC::_total_invocations (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18930/head:pull/18930
$ git checkout pull/18930

Update a local copy of the PR:
$ git checkout pull/18930
$ git pull https://git.openjdk.org/jdk.git pull/18930/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18930

View PR using the GUI difftool:
$ git pr show -t 18930

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18930.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330960: Serial: Remove SerialFullGC::_total_invocations

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 4edac34: 8331167: UBSan enabled build fails in adlc on macOS
• c615c18: 8330158: C2: Loop strip mining uses ABS with min int
• fb63cba: 8330684: ClassFile API runs into StackOverflowError while parsing certain class' bytes
• 4e5c25e: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute
• 16c7dcd: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• c3372c4: 8331134: Port SimpleStringBuilderStrategy to use ClassFile API
• a078b5e: 8331114: Further improve performance of MethodTypeDesc::descriptorString
• e3eb652: 8296543: Update exception documentation for ExecutorService.invokeAll overriders as required
• aa2edd4: 8330686: Fix typos in the DatabaseMetaData javadoc
• aee91fb: 8296175: Output warning if generated docs contain diagnostic markers
• ... and 53 more: https://git.openjdk.org/jdk/compare/5c3838605d48d7f2db981c5e821c08d84856c53c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7ab4a49b)

[lgxbslgx]

Thanks for your reviews.

/integrate

[openjdk]

Going to push as commit 766d0b0.
Since your change was applied there have been 63 commits pushed to the master branch:

• 4edac34: 8331167: UBSan enabled build fails in adlc on macOS
• c615c18: 8330158: C2: Loop strip mining uses ABS with min int
• fb63cba: 8330684: ClassFile API runs into StackOverflowError while parsing certain class' bytes
• 4e5c25e: 8331108: Unused Math.abs call in java.lang.FdLibm.Expm1#compute
• 16c7dcd: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• c3372c4: 8331134: Port SimpleStringBuilderStrategy to use ClassFile API
• a078b5e: 8331114: Further improve performance of MethodTypeDesc::descriptorString
• e3eb652: 8296543: Update exception documentation for ExecutorService.invokeAll overriders as required
• aa2edd4: 8330686: Fix typos in the DatabaseMetaData javadoc
• aee91fb: 8296175: Output warning if generated docs contain diagnostic markers
• ... and 53 more: https://git.openjdk.org/jdk/compare/5c3838605d48d7f2db981c5e821c08d84856c53c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit 766d0b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.