Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331031: unify os::dont_yield and os::naked_yield across Posix platforms #18933

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Apr 24, 2024

The os::dont_yield and os::naked_yield can be unified across Posix platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331031: unify os::dont_yield and os::naked_yield across Posix platforms (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18933/head:pull/18933
$ git checkout pull/18933

Update a local copy of the PR:
$ git checkout pull/18933
$ git pull https://git.openjdk.org/jdk.git pull/18933/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18933

View PR using the GUI difftool:
$ git pr show -t 18933

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18933.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331031: unify os::dont_yield and os::naked_yield across Posix platforms

Reviewed-by: coleenp, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • c9f8d0e: 8331050: Serial: Remove unused _saved_mark_word in DefNewGeneration and TenuredGeneration
  • b1b953c: 8330972: Serial: Inline Generation::max_contiguous_available
  • 87e864b: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0
  • ef745a6: 8331097: Tests build is broken after pr/18914
  • d32f109: 8329797: Shenandoah: Default case invoked for: "MaxL" (bad AD file)
  • ccc0d0f: 8325373: Improve StackCounter error reporting for bad switch cases
  • e818ab6: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • d43654e: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp
  • 21480a7: 8322135: Printing JTable in Windows L&F throws InternalError: HTHEME is null
  • e6118ce: 8331018: Clean up non-standard use of /** comments in jdk.jshell
  • ... and 9 more: https://git.openjdk.org/jdk/compare/45ed97f15b96071e5d6b6d21e8f0129eda5aa447...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8331031: unify os::dont_yield and os::naked_yield across Posix platforms 8331031: unify os::dont_yield and os::naked_yield across Posix platforms Apr 24, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 24, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2024

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 24, 2024
@MBaesken
Copy link
Member Author

Hi Coleen and Martin, thanks for the reviews !

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

Going to push as commit c944201.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 8031dab: 8331094: ZGC: GTest fails due to incompatible Windows version
  • c9f8d0e: 8331050: Serial: Remove unused _saved_mark_word in DefNewGeneration and TenuredGeneration
  • b1b953c: 8330972: Serial: Inline Generation::max_contiguous_available
  • 87e864b: 8328703: Illegal accesses in Java_jdk_internal_org_jline_terminal_impl_jna_linux_CLibraryImpl_ioctl0
  • ef745a6: 8331097: Tests build is broken after pr/18914
  • d32f109: 8329797: Shenandoah: Default case invoked for: "MaxL" (bad AD file)
  • ccc0d0f: 8325373: Improve StackCounter error reporting for bad switch cases
  • e818ab6: 8330815: Use pattern matching for instanceof in KeepAliveCache
  • d43654e: 8331030: langtools/tools/javac/tree tests fail with SOE with fastdebug and -Xcomp
  • 21480a7: 8322135: Printing JTable in Windows L&F throws InternalError: HTHEME is null
  • ... and 10 more: https://git.openjdk.org/jdk/compare/45ed97f15b96071e5d6b6d21e8f0129eda5aa447...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2024
@openjdk openjdk bot closed this Apr 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@MBaesken Pushed as commit c944201.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Comment on lines +857 to +859
bool os::dont_yield() {
return DontYieldALot;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been placed in os.hpp/cpp and removed from all os specific files, but we will be deleting it in JDK 24 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants