Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331113: createJMHBundle.sh support configurable maven repo mirror #18946

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 25, 2024

The script make/devkit/createJMHBundle.sh use fixed maven repo server: https://repo.maven.apache.org/maven2. It's maybe useful to make the maven repo mirror configurable.

Only change devkit shell script, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331113: createJMHBundle.sh support configurable maven repo mirror (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18946/head:pull/18946
$ git checkout pull/18946

Update a local copy of the PR:
$ git checkout pull/18946
$ git pull https://git.openjdk.org/jdk.git pull/18946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18946

View PR using the GUI difftool:
$ git pr show -t 18946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18946.diff

Webrev

Link to Webrev Comment

The script make/devkit/createJMHBundle.sh use fixed maven repo server: https://repo.maven.apache.org/maven2.
It's maybe useful to make the maven repo mirror configurable.

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331113: createJMHBundle.sh support configurable maven repo mirror

Reviewed-by: redestad, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c944201: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 8031dab: 8331094: ZGC: GTest fails due to incompatible Windows version
  • c9f8d0e: 8331050: Serial: Remove unused _saved_mark_word in DefNewGeneration and TenuredGeneration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

Copy link
Member

@cl4es cl4es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 25, 2024
@sendaoYan
Copy link
Member Author

/integrate

@sendaoYan
Copy link
Member Author

Looks reasonable.

Thanks for the review.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@sendaoYan
Your change (at version 14577f9) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member Author

@cl4es @erikj79 Thanks.

@magicus
Copy link
Member

magicus commented Apr 25, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

Going to push as commit ce9eac3.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 5af6b45: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN
  • 4dfaa9b: 8329805: Deprecate for removal ObjectOutputStream.PutField.write
  • b9927aa: 8329194: Cleanup Type::cmp definition and usage
  • c944201: 8331031: unify os::dont_yield and os::naked_yield across Posix platforms
  • 8031dab: 8331094: ZGC: GTest fails due to incompatible Windows version
  • c9f8d0e: 8331050: Serial: Remove unused _saved_mark_word in DefNewGeneration and TenuredGeneration

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 25, 2024
@openjdk openjdk bot closed this Apr 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@magicus @sendaoYan Pushed as commit ce9eac3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants