Skip to content

Conversation

@Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Apr 25, 2024

Hi,
Can you help to review this bug fix patch?
The issue was introduced by JDK-8318650
Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331150: RISC-V: Fix "bad AD file" bug (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18960/head:pull/18960
$ git checkout pull/18960

Update a local copy of the PR:
$ git checkout pull/18960
$ git pull https://git.openjdk.org/jdk.git pull/18960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18960

View PR using the GUI difftool:
$ git pr show -t 18960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18960.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331150: RISC-V: Fix "bad AD file" bug

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b3bcc49: 8330181: Move PcDesc cache from nmethod header
  • 1c238d4: 8319990: Update CLDR to Version 45.0
  • ce9eac3: 8331113: createJMHBundle.sh support configurable maven repo mirror
  • 5af6b45: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2024
@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2024
@Hamlin-Li
Copy link
Author

Thanks @RealFYang for your reviewing.

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

Going to push as commit 006f090.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a407dc9: 8327512: JShell does not work correctly when a class named Object or Throwable is defined
  • ea06129: 8322847: java.lang.classfile.BufWriter should specify @throws for its writeXXX methods
  • b3bcc49: 8330181: Move PcDesc cache from nmethod header
  • 1c238d4: 8319990: Update CLDR to Version 45.0
  • ce9eac3: 8331113: createJMHBundle.sh support configurable maven repo mirror
  • 5af6b45: 8330615: avoid signed integer overflows in zip_util.c readCen / hashN

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2024
@openjdk openjdk bot closed this Apr 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@Hamlin-Li Pushed as commit 006f090.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the fix-bad-ad-file branch May 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants