Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java #18961

Closed
wants to merge 2 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Apr 25, 2024

Could I have a review of a PR that improves logging of a test to be able to debug failures more easily.

Fixes:
Timestamps for all events are written with nanosecond precision
Tests no longer abort before all events have been processed.
Fixed typo of the word ordered

Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/18961/head:pull/18961
$ git checkout pull/18961

Update a local copy of the PR:
$ git checkout pull/18961
$ git pull https://git.openjdk.org/jdk.git pull/18961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 18961

View PR using the GUI difftool:
$ git pr show -t 18961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/18961.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 07facd0: 8330734: JFR: Re-engineer mirror class mechanism
  • 0bf516f: 8330624: Inconsistent use of semicolon in the code snippet of java.io.Serializable javadoc
  • d13e533: 8321014: RISC-V: C2 VectorLoadShuffle
  • 8bbd725: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types
  • 5e2ced4: 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases
  • 2b7176a: 8330625: Compilation memory statistic: prevent tearing of the final report
  • e4ed7ce: 8331063: Some HttpClient tests don't report leaks
  • cfd19f0: 8329850: [AIX] Allow loading of different members of same shared library archive
  • ffd850f: 8309881: Qualified name of a type element depends on its origin (source vs class)
  • 377f2e5: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • ... and 4 more: https://git.openjdk.org/jdk/compare/1c238d43e81acf516297f26660059d0bab5b5b8a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 25, 2024

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Apr 25, 2024
@egahlin egahlin marked this pull request as ready for review April 25, 2024 19:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2024
@egahlin
Copy link
Member Author

egahlin commented Apr 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

Going to push as commit f3bb3e2.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 07facd0: 8330734: JFR: Re-engineer mirror class mechanism
  • 0bf516f: 8330624: Inconsistent use of semicolon in the code snippet of java.io.Serializable javadoc
  • d13e533: 8321014: RISC-V: C2 VectorLoadShuffle
  • 8bbd725: 8331187: Optimize MethodTypeDesc and ClassDesc.ofDescriptor for primitive types
  • 5e2ced4: 8327247: C2 uses up to 2GB of RAM to compile complex string concat in extreme cases
  • 2b7176a: 8330625: Compilation memory statistic: prevent tearing of the final report
  • e4ed7ce: 8331063: Some HttpClient tests don't report leaks
  • cfd19f0: 8329850: [AIX] Allow loading of different members of same shared library archive
  • ffd850f: 8309881: Qualified name of a type element depends on its origin (source vs class)
  • 377f2e5: 8329862: libjli GetApplicationHome cleanups and enhance jli tracing
  • ... and 4 more: https://git.openjdk.org/jdk/compare/1c238d43e81acf516297f26660059d0bab5b5b8a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2024
@openjdk openjdk bot closed this Apr 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 26, 2024
@openjdk
Copy link

openjdk bot commented Apr 26, 2024

@egahlin Pushed as commit f3bb3e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants