8132984: incorrect type for Reference.discovered #1897
Please review this change which fixes the type of the private
I've changed it to Reference and let that flow through, updating some other variables that were previously somewhat incorrectly typed (usually with an Object type parameter). The interesting change is to the ReferenceQueue.enqueue parameter, which is now also Reference.
This ultimately end up with a provably safe and correct, but uncheckable,
An alternative might be to use a raw type for the discovered field, but I
Note that all of the pending list handling, including the discovered field,
The text was updated successfully, but these errors were encountered:
If you introduce a private method in Reference:
...and use it Reference.processPendingReferences while loop like this:
Then you can keep the signature of
But what you have is OK and much better than what was before.
Nice! And this reverts all changes to ReferenceQueue.java
Thanks, but I?m going to take your improvement. I?ll update the PR once I?ve re-run some tests.
@kimbarrett This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the