JDK-8329692 : Add more details to FrameStateTest.java test instructions #19008

honkar-jdk · 2024-04-29T23:24:19Z

For the following manual test, more instructions are added as to what to expect for "hide,iconify and show" vs "hide,iconify,show and restore" for clarity.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8329692: Add more details to FrameStateTest.java test instructions (Bug - P4)

Reviewers

Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to 88f5d048
Alexander Zvegintsev (@azvegint - Reviewer) ⚠️ Review applies to 88f5d048

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19008/head:pull/19008
$ git checkout pull/19008

Update a local copy of the PR:
$ git checkout pull/19008
$ git pull https://git.openjdk.org/jdk.git pull/19008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19008

View PR using the GUI difftool:
$ git pr show -t 19008

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19008.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-04-29T23:25:18Z

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-29T23:25:51Z

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329692: Add more details to FrameStateTest.java test instructions

Reviewed-by: tr, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 157 new commits pushed to the master branch:

7a41a52: 8331549: Inline MemAllocator::mem_allocate_slow
3383ad6: 8331253: 16 bits is not enough for nmethod::_skipped_instructions_size field
8771015: 8331027: JDK's ct.sym file packs corrupted module-info classes
553d45b: 8323724: Remove potential re-inflation from FastHashCode under LM_LIGHTWEIGHT
dd0b641: 8330813: Don't call methods from Compressed(Oops|Klass) if the associated mode is inactive
389f6fe: 8331344: No compiler replay file with CompilerCommand MemLimit
a024eed: 8331478: JFR: Rename printHelp methods for jdk.jfr.internal.dcmd classes
9912abf: 8331011: [XWayland] TokenStorage fails under Security Manager
257a07d: 8331511: Tests should not use the "Classpath" exception form of the legal header
c21672d: 8331077: nroff man page update for jar tool
... and 147 more: https://git.openjdk.org/jdk/compare/83c74d7307e258441abb171552e953f1c6d9b98a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-04-29T23:26:11Z

@honkar-jdk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-04-29T23:29:11Z

Webrevs

kumarabhi006

Since these lines are unchanged, can't add comments there.

AT L155, space after = is missing.
icontst =new CreateFrame(cbIconState.getState(), cbResize.getState());
In CreateFrame constructor, calling pack() is redundant as frame size is set by setBounds(...) method.
L24 to L31 may be removed. Consolidated summary can be defined in jtreg summary tag.

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java

TejeshR13

One observation is that, after the updates the size of whole test window is slightly increased in height where the second Frame which has options is out of the window frame. When the taskbar is at bottom nothing seems to be visible.
One option is to limit the instruction rows or to use PassFailJFrame.splitUI instead of PassFailJFrame.splitUIBottom (Offcourse in splitUI the second Frame occupies the whole screen length which is not required).

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java

honkar-jdk · 2024-04-30T17:18:32Z

One observation is that, after the updates the size of whole test window is slightly increased in height where the second Frame which has options is out of the window frame. When the taskbar is at bottom nothing seems to be visible.
One option is to limit the instruction rows or to use PassFailJFrame.splitUI instead of PassFailJFrame.splitUIBottom (Offcourse in splitUI the second Frame occupies the whole screen length which is not required).

PassFailJFrame.splitUI is not a good option as it causes a lot of empty space in this case. I have reduced the log area instead.

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java

azvegint · 2024-05-02T13:03:31Z

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java

                .instructions(INSTRUCTIONS)
                .testTimeOut(10)
-                .rows(25)
+                .rows(26)


Suggested change

.rows(26)

.rows(27)

It doesn't fit on Linux without scrolling:

(the test is problem listed on Linux, but we can fix it now to avoid coming back to it later)

honkar-jdk · 2024-05-02T16:10:32Z

/integrate

openjdk · 2024-05-02T16:10:56Z

Going to push as commit 6f98d8f.
Since your change was applied there have been 158 commits pushed to the master branch:

6969a9e: 8328999: Update GIFlib to 5.2.2
7a41a52: 8331549: Inline MemAllocator::mem_allocate_slow
3383ad6: 8331253: 16 bits is not enough for nmethod::_skipped_instructions_size field
8771015: 8331027: JDK's ct.sym file packs corrupted module-info classes
553d45b: 8323724: Remove potential re-inflation from FastHashCode under LM_LIGHTWEIGHT
dd0b641: 8330813: Don't call methods from Compressed(Oops|Klass) if the associated mode is inactive
389f6fe: 8331344: No compiler replay file with CompilerCommand MemLimit
a024eed: 8331478: JFR: Rename printHelp methods for jdk.jfr.internal.dcmd classes
9912abf: 8331011: [XWayland] TokenStorage fails under Security Manager
257a07d: 8331511: Tests should not use the "Classpath" exception form of the legal header
... and 148 more: https://git.openjdk.org/jdk/compare/83c74d7307e258441abb171552e953f1c6d9b98a...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-05-02T16:11:02Z

@honkar-jdk Pushed as commit 6f98d8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

honkar-jdk added 2 commits April 29, 2024 16:17

added instructions for clarity

e3758b4

minor update

cc96358

openjdk bot added the rfr Pull request is ready for review label Apr 29, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Apr 29, 2024

kumarabhi006 reviewed Apr 30, 2024

View reviewed changes

TejeshR13 reviewed Apr 30, 2024

View reviewed changes

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java Outdated Show resolved Hide resolved

review changes

b191cc6

honkar-jdk added 2 commits April 30, 2024 10:23

test frame size

bc06131

removed redudant test summary

7a4bacd

kumarabhi006 reviewed Apr 30, 2024

View reviewed changes

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java Outdated Show resolved Hide resolved

minor spacing

fad2ff3

lawrence-andrew reviewed Apr 30, 2024

View reviewed changes

test/jdk/java/awt/Frame/FrameStateTest/FrameStateTest.java Outdated Show resolved Hide resolved

minor

88f5d04

TejeshR13 approved these changes May 2, 2024

View reviewed changes

azvegint approved these changes May 2, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 2, 2024

row count change

20ff464

openjdk bot added the integrated Pull request has been integrated label May 2, 2024

openjdk bot closed this May 2, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2024

JDK-8329692 : Add more details to FrameStateTest.java test instructions #19008

JDK-8329692 : Add more details to FrameStateTest.java test instructions #19008

Uh oh!

Conversation

honkar-jdk commented Apr 29, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Apr 29, 2024

Uh oh!

openjdk bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 29, 2024

Uh oh!

mlbridge bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

kumarabhi006 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TejeshR13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

honkar-jdk commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azvegint May 2, 2024

Choose a reason for hiding this comment

Uh oh!

honkar-jdk commented May 2, 2024

Uh oh!

openjdk bot commented May 2, 2024

Uh oh!

openjdk bot commented May 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

honkar-jdk commented Apr 29, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 29, 2024 •

edited

Loading

mlbridge bot commented Apr 29, 2024 •

edited

Loading

honkar-jdk commented Apr 30, 2024 •

edited

Loading