8331352: error: template-id not allowed for constructor/destructor in C++20 #19009

jankratochvil · 2024-04-30T02:01:01Z

When compiling trunk (819f3d6 2024-04-29) by gcc-14.0.1-0.15.fc40.x86_64 there are many errors:

In file included from src/hotspot/share/memory/allocation.hpp:30,
                 from src/hotspot/share/ci/ciBaseObject.hpp:29,
                 from src/hotspot/share/ci/ciMetadata.hpp:28,
                 from src/hotspot/share/ci/ciType.hpp:28,
                 from src/hotspot/share/ci/ciKlass.hpp:28,
                 from src/hotspot/share/ci/ciArrayKlass.hpp:28,
                 from src/hotspot/share/ci/ciArray.hpp:28,
                 from src/hotspot/share/ci/compilerInterface.hpp:28,
                 from src/hotspot/share/compiler/abstractCompiler.hpp:28,
                 from src/hotspot/share/compiler/abstractCompiler.cpp:25:
src/hotspot/share/utilities/linkedlist.hpp:85:15: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
   85 |   NONCOPYABLE(LinkedList<E>);
      |               ^~~~~~~~~~~~~
src/hotspot/share/utilities/globalDefinitions.hpp:87:26: note: in definition of macro ‘NONCOPYABLE’
   87 | #define NONCOPYABLE(C) C(C const&) = delete; C& operator=(C const&) = delete /* next token must be ; */
      |                          ^
src/hotspot/share/utilities/linkedlist.hpp:85:15: note: remove the ‘< >’
   85 |   NONCOPYABLE(LinkedList<E>);
      |               ^~~~~~~~~~~~~
src/hotspot/share/utilities/globalDefinitions.hpp:87:26: note: in definition of macro ‘NONCOPYABLE’
   87 | #define NONCOPYABLE(C) C(C const&) = delete; C& operator=(C const&) = delete /* next token must be ; */
      |                          ^

In file included from src/hotspot/share/gc/z/zGranuleMap.inline.hpp:30,
                 from src/hotspot/share/gc/z/zForwardingTable.inline.hpp:32,
                 from src/hotspot/share/gc/z/zHeap.inline.hpp:30,
                 from src/hotspot/share/gc/z/zGeneration.inline.hpp:30,
                 from src/hotspot/share/gc/z/zBarrier.inline.hpp:30,
                 from src/hotspot/share/gc/z/zBarrierSet.inline.hpp:31,
                 from src/hotspot/share/gc/shared/barrierSetConfig.inline.hpp:44,
                 from src/hotspot/share/oops/access.inline.hpp:31,
                 from src/hotspot/share/memory/iterator.inline.hpp:32,
                 from src/hotspot/share/oops/oop.inline.hpp:31,
                 from src/hotspot/share/compiler/abstractDisassembler.cpp:32:
src/hotspot/share/gc/z/zArray.inline.hpp:99:21: error: template-id not allowed for destructor in C++20 [-Werror=template-id-cdtor]
   99 | ZActivatedArray<T>::~ZActivatedArray<T>() {
      |                     ^
src/hotspot/share/gc/z/zArray.inline.hpp:99:21: note: remove the ‘< >’

In file included from src/hotspot/share/opto/bytecodeInfo.cpp:38:
src/hotspot/share/utilities/events.hpp:102:18: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
  102 |   EventLogBase<T>(const char* name, const char* handle, int length = LogEventsBufferEntries):
      |                  ^
src/hotspot/share/utilities/events.hpp:102:18: note: remove the ‘< >’

In file included from src/hotspot/share/classfile/metadataOnStackMark.hpp:29,
                 from src/hotspot/share/classfile/classLoaderDataGraph.cpp:30:
src/hotspot/share/utilities/chunkedList.hpp:47:20: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
   47 |   ChunkedList<T, F>() : _top(_values), _next_used(nullptr), _next_free(nullptr) {}
      |                    ^
src/hotspot/share/utilities/chunkedList.hpp:47:20: note: remove the ‘< >’

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Warning

⚠️ Found leading lowercase letter in issue title for 8331352: error: template-id not allowed for constructor/destructor in C++20

Issue

JDK-8331352: error: template-id not allowed for constructor/destructor in C++20 (Bug - P4)

Reviewers

Kim Barrett (@kimbarrett - Reviewer)
Stefan Karlsson (@stefank - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19009/head:pull/19009
$ git checkout pull/19009

Update a local copy of the PR:
$ git checkout pull/19009
$ git pull https://git.openjdk.org/jdk.git pull/19009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19009

View PR using the GUI difftool:
$ git pr show -t 19009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19009.diff

Webrev

Link to Webrev Comment

… C++20

bridgekeeper · 2024-04-30T02:01:42Z

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-04-30T02:02:42Z

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331352: error: template-id not allowed for constructor/destructor in C++20

Reviewed-by: kbarrett, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

d47a4e9: 8332008: Enable issuestitle check
0bf7282: 8331231: containers/docker/TestContainerInfo.java fails
ffbdfff: 8331999: BasicDirectoryModel/LoaderThreadCount.java frequently fails on Windows in CI
c7d98df: 8329691: Support nonlikelyScript parent locale inheritance
aa4cddd: 8331950: Remove MemoryPoolMBean/isCollectionUsageThresholdExceeded from ZGC ProblemLists
c4ff58b: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed
aaa90b3: 8327476: Upgrade JLine to 3.26.1
0a4eeea: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331
ad0b54d: 8314225: SIGSEGV in JavaThread::is_lock_owned
ac86f59: 8330532: Improve line-oriented text parsing in HotSpot
... and 128 more: https://git.openjdk.org/jdk/compare/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @stefank) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-04-30T02:03:02Z

@jankratochvil The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-04-30T02:06:28Z

Webrevs

00: Full (824dab49)

dholmes-ora · 2024-04-30T03:38:59Z

Hotspot does not support C++20 at this time.

I don't know if these changes are harmless wrt. C++17 or may cause an issue.

kimbarrett

The C++20 change comes from DR 2237
https://cplusplus.github.io/CWG/issues/2237.html
That resolution says:
"Note that this resolution is a change for C++20, NOT a defect report against
C++17 and earlier versions."

So it seems like a gcc bug that this error is being issues when not using
C++20. OTOH, the changes involved seem beneficial to me, similarly to those
for JDK-8328997.

Looks good.

jankratochvil · 2024-04-30T04:07:02Z

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/BWHDTXFYHQKR5BZH7QUGX7RQGVUK6DN4/

jankratochvil · 2024-04-30T05:37:14Z

/integrate

openjdk · 2024-04-30T05:38:01Z

@jankratochvil
Your change (at version 824dab4) is now ready to be sponsored by a Committer.

TheShermanTanker · 2024-04-30T09:14:05Z

Seems weird that we're facing C++20 issues when HotSpot is only on C++14. This seems like it should be in the disabled warnings list of HotSpot for erroneous warnings that gcc is giving us, just my 2 cents

kimbarrett · 2024-04-30T18:13:46Z

/integrate

HotSpot changes generally require two reviewers rather than the default one reviewer requirement.
https://openjdk.org/guide/#hotspot-development
Skara doesn't know that, so will prematurely mark a HotSpot change as ready.

kimbarrett · 2024-04-30T18:14:50Z

/reviewers 2

openjdk · 2024-04-30T18:20:31Z

@kimbarrett
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

kimbarrett · 2024-05-01T21:29:02Z

Seems weird that we're facing C++20 issues when HotSpot is only on C++14. This seems like it should be in the disabled warnings list of HotSpot for erroneous warnings that gcc is giving us, just my 2 cents

I agree it's a bit weird that the forward -Wc++N-compat warnings are enabled by -Wall, but presumably the gcc
maintainers have already had that discussion. So long as it's not causing significant problems (and in this case
I think it's not), I don't think we should disable either the forward compat warnings or the specific warnings that
fall under them. If we were going to disable -Wc++20-compat I'd be tempted to re-enable -Wtemplate-id-cdtor
as a thing we don't want folks to do anyway.

jankratochvil · 2024-05-06T08:46:24Z

ping for a reviewer#2 - JDK currently does not build, carrying the off-trunk patches around is a bit annoying. The patch should be then also backported to JDK LTSes.

jankratochvil · 2024-05-06T09:17:56Z

/integrate

openjdk · 2024-05-06T09:19:03Z

@jankratochvil
Your change (at version 824dab4) is now ready to be sponsored by a Committer.

yan-too · 2024-05-10T12:16:23Z

/sponsor

openjdk · 2024-05-10T12:16:48Z

Going to push as commit 45792c5.
Since your change was applied there have been 150 commits pushed to the master branch:

1547a69: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected
784b8fc: 8331744: java.lang.classfile.TypeKind improvements
dea8076: 8332006: Test com/sun/net/httpserver/TcpNoDelayNotRequired.java run timeout with -Xcomp
dab92c5: 8331558: AArch64: optimize integer remainder
9f43ce5: 8330027: Identity hashes of archived objects must be based on a reproducible random seed
d654124: 8331932: Startup regressions in 23-b13
7db6a3f: 8331905: Fix direct includes of g1_globals.hpp
f47fc86: 8331908: Simplify log code in vectorintrinsics.cpp
b9a142a: 8226990: GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
d2d37c9: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
... and 140 more: https://git.openjdk.org/jdk/compare/819f3d6fc70ff6fe54ac5f9033c17c3dd4326aa5...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-05-10T12:16:55Z

@yan-too @jankratochvil Pushed as commit 45792c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

TheShermanTanker · 2024-06-11T00:17:29Z

Ironic that I'm now facing the same issue on Windows:

C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
   93 |   SimpleBufferWithFallback<T, MINIMAL_CAPACITY, OPTIMAL_CAPACITY> ()
      |                                                                   ^
C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: note: remove the '< >'
cc1plus.exe: all warnings being treated as errors

I was going to suppress the warning in the Makefiles, but then remembered about this Pull Request. Should I send a changeset to fix this upstream or just suppress the warning in my Windows/gcc Port?

kimbarrett · 2024-06-11T04:35:23Z

Ironic that I'm now facing the same issue on Windows:
C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
   93 |   SimpleBufferWithFallback<T, MINIMAL_CAPACITY, OPTIMAL_CAPACITY> ()
      |                                                                   ^
C:/users/vertig0/downloads/eclipse-committers-2023-12-r-win32-x86_64/workspace/jdk/src/hotspot/os/windows/symbolengine.cpp:93:67: note: remove the '< >'
cc1plus.exe: all warnings being treated as errors
I was going to suppress the warning in the Makefiles, but then remembered about this Pull Request. Should I send a changeset to fix this upstream or just suppress the warning in my Windows/gcc Port?

I'm okay with having this fixed in openjdk.

8331352: error: template-id not allowed for constructor/destructor in…

824dab4

… C++20

openjdk bot added the rfr Pull request is ready for review label Apr 30, 2024

openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 30, 2024

kimbarrett approved these changes Apr 30, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 30, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 30, 2024

openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Apr 30, 2024

stefank approved these changes May 6, 2024

View reviewed changes

openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels May 6, 2024

openjdk bot added the integrated Pull request has been integrated label May 10, 2024

openjdk bot closed this May 10, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8331352: error: template-id not allowed for constructor/destructor in C++20 #19009

8331352: error: template-id not allowed for constructor/destructor in C++20 #19009

jankratochvil commented Apr 30, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 30, 2024

openjdk bot commented Apr 30, 2024 •

edited

Loading

openjdk bot commented Apr 30, 2024

mlbridge bot commented Apr 30, 2024

dholmes-ora commented Apr 30, 2024

kimbarrett left a comment

jankratochvil commented Apr 30, 2024

jankratochvil commented Apr 30, 2024

openjdk bot commented Apr 30, 2024

TheShermanTanker commented Apr 30, 2024

kimbarrett commented Apr 30, 2024

kimbarrett commented Apr 30, 2024

openjdk bot commented Apr 30, 2024

kimbarrett commented May 1, 2024

jankratochvil commented May 6, 2024

jankratochvil commented May 6, 2024

openjdk bot commented May 6, 2024

yan-too commented May 10, 2024

openjdk bot commented May 10, 2024

openjdk bot commented May 10, 2024

TheShermanTanker commented Jun 11, 2024

kimbarrett commented Jun 11, 2024

8331352: error: template-id not allowed for constructor/destructor in C++20 #19009

8331352: error: template-id not allowed for constructor/destructor in C++20 #19009

Conversation

jankratochvil commented Apr 30, 2024 • edited by openjdk bot Loading

Progress

Warning

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Apr 30, 2024

openjdk bot commented Apr 30, 2024 • edited Loading

openjdk bot commented Apr 30, 2024

mlbridge bot commented Apr 30, 2024

Webrevs

dholmes-ora commented Apr 30, 2024

kimbarrett left a comment

Choose a reason for hiding this comment

jankratochvil commented Apr 30, 2024

jankratochvil commented Apr 30, 2024

openjdk bot commented Apr 30, 2024

TheShermanTanker commented Apr 30, 2024

kimbarrett commented Apr 30, 2024

kimbarrett commented Apr 30, 2024

openjdk bot commented Apr 30, 2024

kimbarrett commented May 1, 2024

jankratochvil commented May 6, 2024

jankratochvil commented May 6, 2024

openjdk bot commented May 6, 2024

yan-too commented May 10, 2024

openjdk bot commented May 10, 2024

openjdk bot commented May 10, 2024

TheShermanTanker commented Jun 11, 2024

kimbarrett commented Jun 11, 2024

jankratochvil commented Apr 30, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Apr 30, 2024 •

edited

Loading