8331392: G1: Make HRPrinter distinguish between different types of reclamation

[tschatzl]

Hi all,

while debugging some unrelated issues using the HRPrinter logging, I found it useful to discriminate between different sources of reclamation in the output. At least "cleanup" seems a bit non-descriptive to me, and only ever fit the case where we "cleaned up" completely empty regions during the Cleanup pause (pre jdk11).

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331392: G1: Make HRPrinter distinguish between different types of reclamation (Enhancement - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)
• Guoxiong Li (@lgxbslgx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19013/head:pull/19013
$ git checkout pull/19013

Update a local copy of the PR:
$ git checkout pull/19013
$ git pull https://git.openjdk.org/jdk.git pull/19013/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19013

View PR using the GUI difftool:
$ git pr show -t 19013

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19013.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331392: G1: Make HRPrinter distinguish between different types of reclamation

Reviewed-by: ayang, iwalulya, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 130 new commits pushed to the master branch:

• b96b38c: 8318682: SA decoding of scalar replaced objects is broken
• a863ef5: 8331207: Misleading example in DateFormat#parse docs
• aca1e83: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• 3d11692: 8331252: C2: MergeStores: handle negative shift values
• 9ce21d1: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow
• 130f71c: 8326742: Change compiler tests without additional VM flags from @run driver to @run main
• f4caac8: 8329138: Convert JFR FileForceEvent to static mirror event
• 2cc8ecc: 8331346: Update PreviewFeature of STREAM_GATHERERS to JEP-473
• 33e8122: 8331410: Remove unused MemAllocator::mem_allocate_inside_tlab
• 22a1c61: 8330817: jdk/internal/vm/Continuation/OSRTest.java times out on libgraal
• ... and 120 more: https://git.openjdk.org/jdk/compare/c4f5c5140a85818152c6e17414a36deabe491f7b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (eb78413e)

[tschatzl]

Thanks @walulyai @albertnetymk @lgxbslgx for your reviews

/integrate

[openjdk]

Going to push as commit fe23068.
Since your change was applied there have been 148 commits pushed to the master branch:

• 33243d4: 8331394: G1: Remove SKIP_RETIRED_FULL_REGIONS define in G1HRPrinter
• 8bcd2e6: 8329088: Stack chunk thawing races with concurrent GC stack iteration
• c4fe5bf: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
• dd906ff: 8331399: RISC-V: Don't us mv instead of la
• d3bf526: 8331518: Tests should not use the "Classpath" exception form of the legal header
• 4036d7d: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API
• 9108091: 8330989: unify os::create_binary_file across platforms
• 5ab8713: 8331360: RISCV: u32 _partial_subtype_ctr loaded/stored as 64
• 19e46ee: 8331088: Incorrect TraceLoopPredicate output
• 0a24dae: 8322043: HeapDumper should use parallel dump by default
• ... and 138 more: https://git.openjdk.org/jdk/compare/c4f5c5140a85818152c6e17414a36deabe491f7b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit fe23068.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.