8278353: Provide Duke as default favicon in Simple Web Server

[sormuras]

Please review this pull request adding a default response for the /favicon.ico path to the Simple Web Server introduced by JEP 408. The image in this PR is a copy of https://inside.java/images/favicon.ico

Before this change, an initial request from a browser yields the following output on the server console:

Binding to loopback by default. For all interfaces use "-b 0.0.0.0" or "-b ::".
Serving PATH and subdirectories on 127.0.0.1 port 8000
URL http://127.0.0.1:8000/
127.0.0.1 - - [30/Apr/2024:13:11:39 +0200] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [30/Apr/2024:13:11:40 +0200] "GET /favicon.ico HTTP/1.1" 404 -

After applying this change set, the two last lines read:

127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [30/Apr/2024:13:12:08 +0200] "GET /favicon.ico HTTP/1.1" 200 -

Note that if the directory being served contains a favicon.ico file it is still sent in favor of the default icon introduced by this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8278353: Provide Duke as default favicon in Simple Web Server (Enhancement - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19020/head:pull/19020
$ git checkout pull/19020

Update a local copy of the PR:
$ git checkout pull/19020
$ git pull https://git.openjdk.org/jdk.git pull/19020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19020

View PR using the GUI difftool:
$ git pr show -t 19020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19020.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278353: Provide Duke as default favicon in Simple Web Server

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
• 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
• 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
• 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
• 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
• 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
• 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
• 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• a2584a8: 8331714: Make OopMapCache installation lock-free
• df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
• ... and 13 more: https://git.openjdk.org/jdk/compare/f1509e007d1538acfb1749f7fafc56be2affd2e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sormuras The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b5156c3d)

[dfuch]

LGTM

[sormuras]

/integrate

[openjdk]

Going to push as commit 7b79426.
Since your change was applied there have been 26 commits pushed to the master branch:

• 466a21d: 8331863: DUIterator_Fast used before it is constructed
• 8af606f: 8331334: com/sun/net/httpserver/HttpsParametersClientAuthTest.java fails in testServerNeedClientAuth(false)
• b910833: 8331864: Update Public Suffix List to 1cbd6e7
• f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
• 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
• 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
• 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
• 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
• 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
• 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
• ... and 16 more: https://git.openjdk.org/jdk/compare/f1509e007d1538acfb1749f7fafc56be2affd2e6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sormuras Pushed as commit 7b79426.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.