8331427: Rename confusingly named ArraysSupport.signedHashCode

[pavelrappo]

Please review this trivial method rename. While this issue was originally spotted in another PR, it makes sense to address it separately. Test results are pending; not that I expect failures, but still.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331427: Rename confusingly named ArraysSupport.signedHashCode (Bug - P4)

Reviewers

• Claes Redestad (@cl4es - Reviewer) ⚠️ Review applies to e83c991f

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19023/head:pull/19023
$ git checkout pull/19023

Update a local copy of the PR:
$ git checkout pull/19023
$ git pull https://git.openjdk.org/jdk.git pull/19023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19023

View PR using the GUI difftool:
$ git pr show -t 19023

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19023.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331427: Rename confusingly named ArraysSupport.signedHashCode

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 44dc850: 8331212: Error recovery for broken switch expressions could be improved
• b2fb5ea: 8331142: Add test for number of loader threads in BasicDirectoryModel
• 663acd2: 8330969: scalability issue with loaded JVMTI agent
• f215899: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64
• b96b38c: 8318682: SA decoding of scalar replaced objects is broken
• a863ef5: 8331207: Misleading example in DateFormat#parse docs
• aca1e83: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• 3d11692: 8331252: C2: MergeStores: handle negative shift values
• 9ce21d1: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow
• 130f71c: 8326742: Change compiler tests without additional VM flags from @run driver to @run main
• ... and 2 more: https://git.openjdk.org/jdk/compare/33e81229bd1b4b28cf2e35f0f8f0a42a04d59c3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@pavelrappo The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (69f56778)
• 00: Full (e83c991f)

[pavelrappo]

Test results were ok.

[pavelrappo]

/integrate

[openjdk]

Going to push as commit 4f529f8.
Since your change was applied there have been 12 commits pushed to the master branch:

• 44dc850: 8331212: Error recovery for broken switch expressions could be improved
• b2fb5ea: 8331142: Add test for number of loader threads in BasicDirectoryModel
• 663acd2: 8330969: scalability issue with loaded JVMTI agent
• f215899: 8331393: AArch64: u32 _partial_subtype_ctr loaded/stored as 64
• b96b38c: 8318682: SA decoding of scalar replaced objects is broken
• a863ef5: 8331207: Misleading example in DateFormat#parse docs
• aca1e83: 8329223: Parallel: Parallel GC resizes heap even if -Xms = -Xmx
• 3d11692: 8331252: C2: MergeStores: handle negative shift values
• 9ce21d1: 8327647: Occasional SIGSEGV in markWord::displaced_mark_helper() for SPECjvm2008 sunflow
• 130f71c: 8326742: Change compiler tests without additional VM flags from @run driver to @run main
• ... and 2 more: https://git.openjdk.org/jdk/compare/33e81229bd1b4b28cf2e35f0f8f0a42a04d59c3d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@pavelrappo Pushed as commit 4f529f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.