8331404: IGV: Show line numbers for callees in properties

[chhagedorn]

IGV shows the bci for a node in the callee, followed by the bci in the caller method and so on until we reach the root method. For the line property, we currently only show the line number found in the root method (first() is the root method being compiled and second() and third() are inlined):

Example program:

Properties of the store to fFld:

One could read the line number from the jvms property above. But you would need to expand that property with the button on the right side which opens a window. But then you cannot click anything else anymore in IGV until you close the window again.

A simpler and easier to read solution is to add the line number information to match the bci numbers (they are printed in callee->root method order which I think is okay - especially if there are a lot of inlinees, it could be easier to have the really interesting numbers at the start on the left side). This would look something like that:

If there is no line number information for a bci, I simply emit a _.

Testing:

• Manual testing in IGV
• Sanity testing by running java -Xcomp -XX:+PrintIdealGraph -XX:PrintIdealGraphLevel=4 -XX:PrintIdealGraphFile=graph.xml HelloWorld.java.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331404: IGV: Show line numbers for callees in properties (Enhancement - P4)

Reviewers

• Tobias Holenstein (@tobiasholenstein - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19025/head:pull/19025
$ git checkout pull/19025

Update a local copy of the PR:
$ git checkout pull/19025
$ git pull https://git.openjdk.org/jdk.git pull/19025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19025

View PR using the GUI difftool:
$ git pr show -t 19025

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19025.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331404: IGV: Show line numbers for callees in properties

Reviewed-by: tholenstein, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 9912abf: 8331011: [XWayland] TokenStorage fails under Security Manager
• 257a07d: 8331511: Tests should not use the "Classpath" exception form of the legal header
• c21672d: 8331077: nroff man page update for jar tool
• cccc953: 8329258: TailCall should not use frame pointer register for jump target
• 4a78906: 8331537: Test code should not use the "Classpath" exception clause
• 2056968: 8331513: Tests should not use the "Classpath" exception form of the legal header
• c9255f3: 8331514: Tests should not use the "Classpath" exception form of the legal header
• beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
• ae82405: 8323058: Revisit j.l.classfile.CodeBuilder API surface
• 286cbf8: 8331546: Build failure after 8330076
• ... and 33 more: https://git.openjdk.org/jdk/compare/b128bd7b5a1dcf3e7a55d3e3b0c4a9998bde963e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4c9dda04)

[tobiasholenstein]

Looks good!

[chhagedorn]

Thanks Toby for your review!

[TobiHartmann]

Looks good to me too.

[chhagedorn]

Thanks Tobias for your review!

/integrate

[openjdk]

Going to push as commit 8bc641e.
Since your change was applied there have been 61 commits pushed to the master branch:

• 7c1fad4: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 6bef047: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize
• 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• f6cdcc6: 8280988: [XWayland] Click on title to request focus test failures
• 99654ec: 8331516: Tests should not use the "Classpath" exception form of the legal header
• cd3a607: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()
• 73cdc9a: 8326421: Add jtreg test for large arrayCopy disjoint case.
• e2c0cfe: 8331320: ClassFile API OutOfMemoryError with certain class files
• 6f98d8f: 8329692: Add more details to FrameStateTest.java test instructions
• ... and 51 more: https://git.openjdk.org/jdk/compare/b128bd7b5a1dcf3e7a55d3e3b0c4a9998bde963e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 8bc641e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.