Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all #19033

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 1, 2024

Hi,
GHA runner shows that serviceability/dcmd/gc/RunFinalizationTest.java intermittent fail on macos-aarch64. The testcase has been problemlisted on linux-all,windows-x64,aix-ppc64. I think we should add the problemlist with macos-aarch64.

Only change the ProblemList, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19033/head:pull/19033
$ git checkout pull/19033

Update a local copy of the PR:
$ git checkout pull/19033
$ git pull https://git.openjdk.org/jdk.git pull/19033/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19033

View PR using the GUI difftool:
$ git pr show -t 19033

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19033.diff

Webrev

Link to Webrev Comment

…on macos-aarch64

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sspitsyn, @plummercj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@sendaoYan
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@sendaoYan
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@sendaoYan
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 1, 2024

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2024
@sendaoYan
Copy link
Member Author

/integrate

@sendaoYan
Copy link
Member Author

Looks okay to me.

@sspitsyn Thanks.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 5, 2024
@openjdk
Copy link

openjdk bot commented May 5, 2024

@sendaoYan
Your change (at version 16aa527) is now ready to be sponsored by a Committer.

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label May 8, 2024
@sendaoYan
Copy link
Member Author

@sspitsyn Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@sendaoYan
Your change (at version fc1ef65) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member Author

@plummercj Thanks for the approved.

@openjdk openjdk bot removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels May 9, 2024
@dcubed-ojdk
Copy link
Member

I've updated the bug's sysnopsis:

s/macos-aarch64/generic-all/

The fastest way to update the PR's title is with /issue JDK-8331466

@sendaoYan sendaoYan changed the title 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on macos-aarch64 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all May 10, 2024
@openjdk openjdk bot added sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels May 10, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented May 10, 2024

I've updated the bug's sysnopsis:

s/macos-aarch64/generic-all/

The fastest way to update the PR's title is with /issue JDK-8331466

@dcubed-ojdk Thanks.

@sendaoYan
Copy link
Member Author

/issue JDK-8331466

@openjdk
Copy link

openjdk bot commented May 10, 2024

@sendaoYan This issue is referenced in the PR title - it will now be updated.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 10, 2024

@sendaoYan
Your change (at version fc1ef65) is now ready to be sponsored by a Committer.

@sspitsyn
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit 440782e.
Since your change was applied there have been 155 commits pushed to the master branch:

  • 5ded8da: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • 7c2c24f: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • ff4bf1c: 8332102: Add @since to package-info of jdk.security.jarsigner
  • abf54bb: 8332100: Add missing @since to KeyValue::EC_TYPE in java.xml.crypto
  • 1484153: 8332080: Update troff man page for javadoc
  • 391bbbc: 8330584: IGV: XML does not save all node properties
  • adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
  • 5a8df41: 8331535: Incorrect prompt for Console.readLine
  • 3e3f7cf: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
  • d517d2d: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
  • ... and 145 more: https://git.openjdk.org/jdk/compare/4f529f8c232b4082aa4aa39766bcf42b09885ee4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@sspitsyn @sendaoYan Pushed as commit 440782e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

@sendaoYan sendaoYan deleted the jbs8331466 branch July 1, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants