Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only #19038

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented May 1, 2024

As soon as I integrated test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java #18957, the test started failing in CI on Linux and macOS. There are six failures found so far.

Before starting code review and later, I ran the test many times on CI and I never saw so many failures.

To reduce the noise, I'm limiting the test to Windows only where it's stable.

I submitted JDK-8331494 to make the test more stable on Linux and macOS if possible.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19038/head:pull/19038
$ git checkout pull/19038

Update a local copy of the PR:
$ git checkout pull/19038
$ git pull https://git.openjdk.org/jdk.git pull/19038/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19038

View PR using the GUI difftool:
$ git pr show -t 19038

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19038.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 1, 2024
@mlbridge
Copy link

mlbridge bot commented May 1, 2024

Webrevs

@aivanov-jdk
Copy link
Member Author

@mrserb Could you approve it, please? Or anyone else.

This is trivial change, I'll enable automatic integration as soon as it's reviewed.

@aivanov-jdk
Copy link
Member Author

/integrate auto

@openjdk openjdk bot added the auto label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@aivanov-jdk This pull request will be automatically integrated when it is ready

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One reviewer is OK here.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 1, 2024

Going to push as commit 2a95cd4.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 1, 2024
@openjdk openjdk bot closed this May 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@openjdk[bot] Pushed as commit 2a95cd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8331495-limit-to-Windows branch May 1, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants