Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331077 : nroff man page update for jar tool #19039

Closed
wants to merge 2 commits into from

Conversation

weibxiao
Copy link
Contributor

@weibxiao weibxiao commented May 1, 2024

nroff man page update for jar tool.

This update is caused by the change of https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331077: nroff man page update for jar tool (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19039/head:pull/19039
$ git checkout pull/19039

Update a local copy of the PR:
$ git checkout pull/19039
$ git pull https://git.openjdk.org/jdk.git pull/19039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19039

View PR using the GUI difftool:
$ git pr show -t 19039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19039.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 1, 2024

👋 Welcome back wxiao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 1, 2024

@weibxiao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331077: nroff man page update for jar tool

Reviewed-by: jjg, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • cccc953: 8329258: TailCall should not use frame pointer register for jump target
  • 4a78906: 8331537: Test code should not use the "Classpath" exception clause
  • 2056968: 8331513: Tests should not use the "Classpath" exception form of the legal header
  • c9255f3: 8331514: Tests should not use the "Classpath" exception form of the legal header
  • beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
  • ae82405: 8323058: Revisit j.l.classfile.CodeBuilder API surface
  • 286cbf8: 8331546: Build failure after 8330076
  • fe23068: 8331392: G1: Make HRPrinter distinguish between different types of reclamation
  • 33243d4: 8331394: G1: Remove SKIP_RETIRED_FULL_REGIONS define in G1HRPrinter
  • 8bcd2e6: 8329088: Stack chunk thawing races with concurrent GC stack iteration
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e833bfc8ac6104522d037e7eb300f5aa112688bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons, @coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 1, 2024
@openjdk
Copy link

openjdk bot commented May 1, 2024

@weibxiao The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels May 1, 2024
@mlbridge
Copy link

mlbridge bot commented May 1, 2024

Webrevs

@@ -35,7 +35,7 @@
. ftr VB CB
. ftr VBI CBI
.\}
.TH "JAR" "1" "2024" "JDK 23-ea" "JDK Commands"
.TH "JAR" "1" "2024" "JDK 23-internal" "JDK Commands"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remain as ea -- not internal

@weibxiao
Copy link
Contributor Author

weibxiao commented May 1, 2024

reverted to "JDK 23-ea"

Copy link
Contributor

@coffeys coffeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 1, 2024
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as corresponding to the upstream Markdown file.

That being said, the descriptions about arg files in lines 334-343 look somewhat clunky, and could benefit from some improvements in a later update.

@weibxiao
Copy link
Contributor Author

weibxiao commented May 2, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

@weibxiao
Your change (at version b0ef5df) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented May 2, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 2, 2024

Going to push as commit c21672d.
Since your change was applied there have been 20 commits pushed to the master branch:

  • cccc953: 8329258: TailCall should not use frame pointer register for jump target
  • 4a78906: 8331537: Test code should not use the "Classpath" exception clause
  • 2056968: 8331513: Tests should not use the "Classpath" exception form of the legal header
  • c9255f3: 8331514: Tests should not use the "Classpath" exception form of the legal header
  • beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
  • ae82405: 8323058: Revisit j.l.classfile.CodeBuilder API surface
  • 286cbf8: 8331546: Build failure after 8330076
  • fe23068: 8331392: G1: Make HRPrinter distinguish between different types of reclamation
  • 33243d4: 8331394: G1: Remove SKIP_RETIRED_FULL_REGIONS define in G1HRPrinter
  • 8bcd2e6: 8329088: Stack chunk thawing races with concurrent GC stack iteration
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e833bfc8ac6104522d037e7eb300f5aa112688bb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2024
@openjdk openjdk bot closed this May 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

@coffeys @weibxiao Pushed as commit c21672d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants