-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331077 : nroff man page update for jar tool #19039
Conversation
👋 Welcome back wxiao! A progress list of the required criteria for merging this PR into |
@weibxiao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons, @coffeys) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
src/jdk.jartool/share/man/jar.1
Outdated
@@ -35,7 +35,7 @@ | |||
. ftr VB CB | |||
. ftr VBI CBI | |||
.\} | |||
.TH "JAR" "1" "2024" "JDK 23-ea" "JDK Commands" | |||
.TH "JAR" "1" "2024" "JDK 23-internal" "JDK Commands" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remain as ea
-- not internal
reverted to "JDK 23-ea" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, as corresponding to the upstream Markdown file.
That being said, the descriptions about arg files in lines 334-343 look somewhat clunky, and could benefit from some improvements in a later update.
/integrate |
/sponsor |
Going to push as commit c21672d.
Your commit was automatically rebased without conflicts. |
nroff man page update for jar tool.
This update is caused by the change of https://bugs.openjdk.org/browse/JDK-8318971. While the .md man pages got updated in other repos, the corresponding nroff man page was never updated in OpenJDK repos
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19039/head:pull/19039
$ git checkout pull/19039
Update a local copy of the PR:
$ git checkout pull/19039
$ git pull https://git.openjdk.org/jdk.git pull/19039/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19039
View PR using the GUI difftool:
$ git pr show -t 19039
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19039.diff
Webrev
Link to Webrev Comment