Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331514: Tests should not use the "Classpath" exception form of the legal header #19046

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented May 2, 2024

Can I please get a review of this copyright text only change which removes the "Classpath" exception from the test/jdk/java/lang/ProcessBuilder/JspawnhelperWarnings.java test file and thus addresses https://bugs.openjdk.org/browse/JDK-8331514?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331514: Tests should not use the "Classpath" exception form of the legal header (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19046/head:pull/19046
$ git checkout pull/19046

Update a local copy of the PR:
$ git checkout pull/19046
$ git pull https://git.openjdk.org/jdk.git pull/19046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19046

View PR using the GUI difftool:
$ git pr show -t 19046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19046.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2024

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2024

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331514: Tests should not use the "Classpath" exception form of the legal header

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 33243d4: 8331394: G1: Remove SKIP_RETIRED_FULL_REGIONS define in G1HRPrinter
  • 8bcd2e6: 8329088: Stack chunk thawing races with concurrent GC stack iteration
  • c4fe5bf: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
  • dd906ff: 8331399: RISC-V: Don't us mv instead of la
  • d3bf526: 8331518: Tests should not use the "Classpath" exception form of the legal header
  • 4036d7d: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API
  • 9108091: 8330989: unify os::create_binary_file across platforms
  • 5ab8713: 8331360: RISCV: u32 _partial_subtype_ctr loaded/stored as 64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

@jaikiran The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 2, 2024
@jaikiran jaikiran changed the title 8331514: Tests should not use the Classpath exception form of the legal header 8331514: Tests should not use the "Classpath" exception form of the legal header May 2, 2024
@mlbridge
Copy link

mlbridge bot commented May 2, 2024

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2024
@jaikiran
Copy link
Member Author

jaikiran commented May 2, 2024

Thank you Daniel for the review.

@jaikiran
Copy link
Member Author

jaikiran commented May 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2024

Going to push as commit c9255f3.
Since your change was applied there have been 12 commits pushed to the master branch:

  • beebce0: 8331421: ubsan: vmreg.cpp checking error member call on misaligned address
  • ae82405: 8323058: Revisit j.l.classfile.CodeBuilder API surface
  • 286cbf8: 8331546: Build failure after 8330076
  • fe23068: 8331392: G1: Make HRPrinter distinguish between different types of reclamation
  • 33243d4: 8331394: G1: Remove SKIP_RETIRED_FULL_REGIONS define in G1HRPrinter
  • 8bcd2e6: 8329088: Stack chunk thawing races with concurrent GC stack iteration
  • c4fe5bf: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
  • dd906ff: 8331399: RISC-V: Don't us mv instead of la
  • d3bf526: 8331518: Tests should not use the "Classpath" exception form of the legal header
  • 4036d7d: 8330076: NMT: add/make a mandatory MEMFLAGS argument to family of os::reserve/commit/uncommit memory API
  • ... and 2 more: https://git.openjdk.org/jdk/compare/19e46eed580339a61fd1309c2cc7040e8c83597d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2024
@openjdk openjdk bot closed this May 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2024
@openjdk
Copy link

openjdk bot commented May 2, 2024

@jaikiran Pushed as commit c9255f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8331514 branch May 2, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants