8258955: XBuffer.slice(int,int) fails to adjust index according to primitive size

[ChrisHegarty]

Scale the slice start index per carrier width, for views of direct byte buffers. This never worked correctly since being added in Java 13.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8258955

Issue

• JDK-8258955: (bf) slice(int, int) on view buffers fails to adjust index according to primitive size ⚠️ Title mismatch between PR and JBS.

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1906/head:pull/1906
$ git checkout pull/1906

[bridgekeeper]

👋 Welcome back chegar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ChrisHegarty The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (898e9ac)

[AlanBateman]

Thanks for picking this up an oversight when it was added in Java 13 and something we missed when reviewing and testing.

As this is a P3 issue then we could potentially fix this in openjdk/jdk16 during RDP1. If not, it might be something to put into 16.0.1 or 16.0.2.

[ChrisHegarty]

Closing this PR. Instead a PR has been raised against the jdk16 fork, see openjdk/jdk16#73.