8331402: G1: Remove is_active() calls in G1HRPrinter logging

[tschatzl]

Hi all,

the is_active() call for the various G1HRPrinter methods is unnecessary as the log_trace() call will do the exact same check again anyway.

Testing: gha, local compilation

Based on #19058.

Hth,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331402: G1: Remove is_active() calls in G1HRPrinter logging (Enhancement - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer) ⚠️ Review applies to 25f24c1a
• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to 25f24c1a
• Guoxiong Li (@lgxbslgx - Committer) ⚠️ Review applies to 25f24c1a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19061/head:pull/19061
$ git checkout pull/19061

Update a local copy of the PR:
$ git checkout pull/19061
$ git pull https://git.openjdk.org/jdk.git pull/19061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19061

View PR using the GUI difftool:
$ git pr show -t 19061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19061.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into pr/19058 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331402: G1: Remove is_active() calls in G1HRPrinter logging

Reviewed-by: iwalulya, ayang, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a94a2b18)
• 01: Full - Incremental (25f24c1a)
• 00: Full (25f24c1a)

[lgxbslgx]

Looks good.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout submit/8331402-g1hrprinter-remove-is_active
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[tschatzl]

Thanks @albertnetymk @lgxbslgx @walulyai for your reviews

/integrate

[openjdk]

Going to push as commit 58ef9e4.

[openjdk]

@tschatzl Pushed as commit 58ef9e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.