8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs

[shipilev]

CollectedHeap::is_gc_active() is confusing, since its name implies any GC phase is running, while it actually only covers the STW GCs. It would be good to rename it for clarity. The freed-up name, is_gc_active could then be repurposed to track any (concurrent or STW) GC phase running. That would be useful to resolve JDK-8331572.

Doing this rename separately guarantees we have caught and renamed all current uses.

Additional testing:

• Linux AArch64 server fastdebug, all

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)
• Guoxiong Li (@lgxbslgx - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19064/head:pull/19064
$ git checkout pull/19064

Update a local copy of the PR:
$ git checkout pull/19064
$ git pull https://git.openjdk.org/jdk.git pull/19064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19064

View PR using the GUI difftool:
$ git pr show -t 19064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19064.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs

Reviewed-by: stefank, zgu, tschatzl, gli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• a10845b: 8330539: Use #include <alloca.h> instead of -Dalloca'(size)'=__builtin_alloca'(size)' for AIX
• 8bc641e: 8331404: IGV: Show line numbers for callees in properties
• 7c1fad4: 8329559: Test javax/swing/JFrame/bug4419914.java failed because The End and Start buttons are not placed correctly and Tab focus does not move as expected
• 6bef047: 8272364: Parallel GC adaptive size policy may shrink the heap below MinHeapSize
• 01125fa: 8331605: jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java test failure
• 04271df: 8331331: :tier1 target explanation in doc/testing.md is incorrect
• f6cdcc6: 8280988: [XWayland] Click on title to request focus test failures
• 99654ec: 8331516: Tests should not use the "Classpath" exception form of the legal header
• cd3a607: 8328864: NullPointerException in sun.security.jca.ProviderList.getService()
• 73cdc9a: 8326421: Add jtreg test for large arrayCopy disjoint case.
• ... and 6 more: https://git.openjdk.org/jdk/compare/553d45b11460a794613651373f34c8379c11729b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• graal
• hotspot
• serviceability
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5ae066fd)

[stefank]

Seems like a good change.

[zhengyu123]

LGTM

[lgxbslgx]

Looks good.

[lgxbslgx]

/label hotspot-gc

[openjdk]

@lgxbslgx
The hotspot-gc label was successfully added.

[shipilev]

Thanks all!

/integrate

[openjdk]

Going to push as commit 1eec30a.
Since your change was applied there have been 42 commits pushed to the master branch:

• e8a2d56: 8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java
• 9b0bb03: 8331285: Deprecate and obsolete OldSize
• 6c77641: 8331418: ZGC: generalize barrier liveness logic
• 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
• 4bbd972: 8305638: Renaming and small clean-ups around predicates
• f1509e0: 8330998: System.console() writes to stderr when stdout is redirected
• f2c4a41: 8328481: Implement JEP 476: Module Import Declarations (Preview)
• 9347bb7: 8330247: C2: CTW fail with assert(adr_t->is_known_instance_field()) failed: instance required
• b20fa7b: 8329982: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found
• c1a1645: 8331655: ClassFile API ClassCastException with verbose output of certain class files
• ... and 32 more: https://git.openjdk.org/jdk/compare/553d45b11460a794613651373f34c8379c11729b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 1eec30a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.