Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4 #19077

Closed
wants to merge 1 commit into from
Closed

8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4 #19077

wants to merge 1 commit into from

Conversation

Bhavana-Kilambi
Copy link
Contributor

@Bhavana-Kilambi Bhavana-Kilambi commented May 3, 2024 •
edited by openjdk bot
Loading

This commit - [1] modified the aarch64_vector.ad directly. This patch includes that change in the aarch64_vector_ad.m4 file as well and generates the aarch64_vector.ad file from it.

[1] 185e711

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4 (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19077/head:pull/19077
$ git checkout pull/19077

Update a local copy of the PR:
$ git checkout pull/19077
$ git pull https://git.openjdk.org/jdk.git pull/19077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19077

View PR using the GUI difftool:
$ git pr show -t 19077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19077.diff

Webrev

Link to Webrev Comment

@Bhavana-Kilambi
8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4
f4157c7 
This commit - [1] modified the aarch64_vector.ad directly. This patch
includes that change in the aarch64_vector_ad.m4 file as well and
generates the aarch64_vector.ad file from it.

[1] openjdk@185e711
@Bhavana-Kilambi Bhavana-Kilambi marked this pull request as ready for review May 3, 2024 09:07
@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2024

👋 Welcome back bkilambi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 3, 2024 •
edited
Loading

@Bhavana-Kilambi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4

Reviewed-by: aph, kvn, eliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • a8b3f19: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT
  • ae60d84: 8328501: Incorrect @since tags for java security interfaces
  • 7a35f92: 8331660: Parallel: Cleanup includes in parallelScavangeHeap files
  • fa02667: 8322726: C2: Unloaded signature class kills argument value
  • a8e62af: 8331389: runtime/ErrorHandling/TestDwarf.java fails with "Crash JVM should not exit gracefully"
  • 1eec30a: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • e8a2d56: 8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java
  • 9b0bb03: 8331285: Deprecate and obsolete OldSize
  • 6c77641: 8331418: ZGC: generalize barrier liveness logic
  • 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
  • ... and 22 more: https://git.openjdk.org/jdk/compare/a10845b553fc6fe7e06a0f37ce73fe5f704dc7c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @vnkozlov, @e1iu) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 3, 2024
@openjdk
Copy link

openjdk bot commented May 3, 2024

@Bhavana-Kilambi The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 3, 2024
@mlbridge
Copy link

mlbridge bot commented May 3, 2024

Webrevs

theRealAph
theRealAph approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@theRealAph theRealAph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Obvious/trivial.
Daaamn, that shouldn't have happened. It did happen, though, because the patch wasn't AArch64-specific so none of the AArch64 noticed it. I'm a bit reluctant to splatter aarch64_vector.ad with

// DO NOT EDIT ANYTHING IN THIS SECTION OF THE FILE

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 3, 2024
@Bhavana-Kilambi
Copy link
Contributor Author

Thanks for the review. This rarely happens though. I shouldn't have missed this.
Can I integrate it or shall I wait for another review (as we need two reviews these days but this one is trivial)?
Will still wait for all the tests on macos to pass.

vnkozlov
vnkozlov approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@theRealAph
Copy link
Contributor

Thanks for the review. This rarely happens though. I shouldn't have missed this. Can I integrate it or shall I wait for another review (as we need two reviews these days but this one is trivial)? Will still wait for all the tests on macos to pass.

Just push it. @vnkozlov has acked it now.

@Bhavana-Kilambi
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

@Bhavana-Kilambi
Your change (at version f4157c7) is now ready to be sponsored by a Committer.

@e1iu
Copy link
Member

e1iu commented May 6, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented May 6, 2024

Going to push as commit f308e10.
Since your change was applied there have been 32 commits pushed to the master branch:

  • a8b3f19: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT
  • ae60d84: 8328501: Incorrect @since tags for java security interfaces
  • 7a35f92: 8331660: Parallel: Cleanup includes in parallelScavangeHeap files
  • fa02667: 8322726: C2: Unloaded signature class kills argument value
  • a8e62af: 8331389: runtime/ErrorHandling/TestDwarf.java fails with "Crash JVM should not exit gracefully"
  • 1eec30a: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
  • e8a2d56: 8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java
  • 9b0bb03: 8331285: Deprecate and obsolete OldSize
  • 6c77641: 8331418: ZGC: generalize barrier liveness logic
  • 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
  • ... and 22 more: https://git.openjdk.org/jdk/compare/a10845b553fc6fe7e06a0f37ce73fe5f704dc7c4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2024
@openjdk openjdk bot closed this May 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

@e1iu @Bhavana-Kilambi Pushed as commit f308e10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e1iu e1iu e1iu approved these changes

@vnkozlov vnkozlov vnkozlov approved these changes

@theRealAph theRealAph theRealAph approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bhavana-Kilambi @theRealAph @e1iu @vnkozlov