8330278: Have SSLSocketTemplate.doClientSide use loopback address

[coffeys]

Using the loopback address by default may prove more reliable for some test configurations

ran all jdk_security tests. no issues seen.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330278: Have SSLSocketTemplate.doClientSide use loopback address (Bug - P4)

Reviewers

• Sibabrata Sahoo (@sisahoo - Committer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19083/head:pull/19083
$ git checkout pull/19083

Update a local copy of the PR:
$ git checkout pull/19083
$ git pull https://git.openjdk.org/jdk.git pull/19083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19083

View PR using the GUI difftool:
$ git pr show -t 19083

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19083.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330278: Have SSLSocketTemplate.doClientSide use loopback address

Reviewed-by: ssahoo, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• a8b3f19: 8330077: Allow max number of events to be buffered to be configurable to avoid OVERFLOW_EVENT
• ae60d84: 8328501: Incorrect @since tags for java security interfaces
• 7a35f92: 8331660: Parallel: Cleanup includes in parallelScavangeHeap files
• fa02667: 8322726: C2: Unloaded signature class kills argument value
• a8e62af: 8331389: runtime/ErrorHandling/TestDwarf.java fails with "Crash JVM should not exit gracefully"
• 1eec30a: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
• e8a2d56: 8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java
• 9b0bb03: 8331285: Deprecate and obsolete OldSize
• 6c77641: 8331418: ZGC: generalize barrier liveness logic
• 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
• ... and 22 more: https://git.openjdk.org/jdk/compare/a10845b553fc6fe7e06a0f37ce73fe5f704dc7c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coffeys The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (489e269b)

[mpdonova]

looks good to me.

[coffeys]

/integrate

[openjdk]

Going to push as commit 0eff492.
Since your change was applied there have been 52 commits pushed to the master branch:

• c6f611c: 8331798: Remove unused arg of checkErgonomics() in TestMaxHeapSizeTools.java
• 0e1dca7: 8331715: Remove virtual specifiers in ContiguousSpace
• 7f29904: 8330005: RandomGeneratorFactory.getDefault() throws exception when the runtime image only has java.base module
• 2baacfc: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
• 7b79426: 8278353: Provide Duke as default favicon in Simple Web Server
• 466a21d: 8331863: DUIterator_Fast used before it is constructed
• 8af606f: 8331334: com/sun/net/httpserver/HttpsParametersClientAuthTest.java fails in testServerNeedClientAuth(false)
• b910833: 8331864: Update Public Suffix List to 1cbd6e7
• f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
• 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
• ... and 42 more: https://git.openjdk.org/jdk/compare/a10845b553fc6fe7e06a0f37ce73fe5f704dc7c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coffeys Pushed as commit 0eff492.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.