8331655: ClassFile API ClassCastException with verbose output of certain class files

[asotona]

Specifically corrupted constant pool of a class file can cause ClassCastException, when the entries are accessed by Class-File API in exact order.

This fix avoids the ClassCastException and throws ConstantPoolException instead.
Test is attached.

Please review.

Thanks,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331655: ClassFile API ClassCastException with verbose output of certain class files (Bug - P4)

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19088/head:pull/19088
$ git checkout pull/19088

Update a local copy of the PR:
$ git checkout pull/19088
$ git pull https://git.openjdk.org/jdk.git pull/19088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19088

View PR using the GUI difftool:
$ git pr show -t 19088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19088.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331655: ClassFile API ClassCastException with verbose output of certain class files

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• b33096f: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory
• cf2c80e: 8331582: Incorrect default Console provider comment
• 77b7122: 8312104: Update java man pages to include new security category in -XshowSettings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2e94a1b0)
• 00: Full (59191c6f)

[PaulSandoz]

Can we call into the tag accepting entryByIndex? e.g.,

if (entryByIndex(index, TAG_UTF8) instanceof AbstractPoolEntry.Utf8EntryImpl utf8) {
  return ...
}
throw new ...

?

[asotona]

Yes, it is a good opportunity to reduce the code a bit.
Thanks!

[PaulSandoz]

Nice!

[asotona]

/integrate

[openjdk]

Going to push as commit c1a1645.
Since your change was applied there have been 4 commits pushed to the master branch:

• 36c9607: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused
• b33096f: 8295153: java/util/Base64/TestEncodingDecodingLength.java ran out of memory
• cf2c80e: 8331582: Incorrect default Console provider comment
• 77b7122: 8312104: Update java man pages to include new security category in -XshowSettings

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit c1a1645.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.