Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert #1909

Closed
wants to merge 1 commit into from

Conversation

Wanghuang-Huawei
Copy link

@Wanghuang-Huawei Wanghuang-Huawei commented Dec 30, 2020

$java --add-modules=jdk.incubator.vector -Xcomp -XX:CompileCommand=compileonly,TestCast16BTo2D::* -XX:+UnlockDiagnosticVMOptions -XX:+PrintIntrinsics TestCast16BTo2D
before fixing:
  ** not supported: arity=1 op=cast/5 vlen2=2 etype1=byte ismask=0
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                      @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
                                      @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                    @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
                                      @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) failed to inline (intrinsic)
                                @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)
Expect:
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                      @ 101 java.lang.Object::getClass (0 bytes) (intrinsic)
                                      @ 109 java.lang.Object::getClass (0 bytes) (intrinsic)
                                    @ 3 jdk.internal.util.Preconditions::checkIndex (18 bytes) (intrinsic)
                                    @ 31 jdk.internal.vm.vector.VectorSupport::load (38 bytes) (intrinsic)
                                      @ 128 jdk.internal.vm.vector.VectorSupport::convert (39 bytes) (intrinsic)
                                @ 42 jdk.internal.vm.vector.VectorSupport::store (38 bytes) (intrinsic)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258989: JVM is failed to inline in jdk.internal.vm.vector.VectorSupport::convert

Contributors

  • He Xuejin <hexuejin2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1909/head:pull/1909
$ git checkout pull/1909

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 30, 2020

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 30, 2020
@openjdk
Copy link

openjdk bot commented Dec 30, 2020

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 30, 2020
@openjdk
Copy link

openjdk bot commented Dec 30, 2020

@Wanghuang-Huawei Could not parse He Xuejin hexuejin2@huawei.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@Wanghuang-Huawei
Copy link
Author

Wanghuang-Huawei commented Dec 30, 2020

/contributor add He Xuejin hexuejin2@huawei.com

@openjdk
Copy link

openjdk bot commented Dec 30, 2020

@Wanghuang-Huawei
Contributor He Xuejin <hexuejin2@huawei.com> successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 30, 2020

Webrevs

Copy link

@iwanowww iwanowww left a comment

The fix itself looks good, but I think it should be fixed in 16 as well.

Please, re-post the PR against 16.

@Wanghuang-Huawei
Copy link
Author

Wanghuang-Huawei commented Dec 30, 2020

The fix itself looks good, but I think it should be fixed in 16 as well.

Please, re-post the PR against 16.

Should I report a new bug and a new PR against 17 ?

@iwanowww
Copy link

iwanowww commented Dec 30, 2020

Should I report a new bug and a new PR against 17 ?

No need to, fixes from 16 are automatically forward-ported into the mainline (17).

@Wanghuang-Huawei
Copy link
Author

Wanghuang-Huawei commented Dec 31, 2020

Should I report a new bug and a new PR against 17 ?

No need to, fixes from 16 are automatically forward-ported into the mainline (17).

OK. I have posted PR against 16. openjdk/jdk16#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review
2 participants