8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java

[egahlin]

Could I have a review of a change that improves logging for a test that fails intermittently.

Testing: 300 x jdk/jfr/api/consumer/recordingstream;TestStop.java

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java (Sub-task - P4)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19090/head:pull/19090
$ git checkout pull/19090

Update a local copy of the PR:
$ git checkout pull/19090
$ git pull https://git.openjdk.org/jdk.git pull/19090/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19090

View PR using the GUI difftool:
$ git pr show -t 19090

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19090.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331653: JFR: Improve logging for jdk/jfr/api/consumer/recordingstream;TestStop.java

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 9b0bb03: 8331285: Deprecate and obsolete OldSize
• 6c77641: 8331418: ZGC: generalize barrier liveness logic
• 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
• 4bbd972: 8305638: Renaming and small clean-ups around predicates
• f1509e0: 8330998: System.console() writes to stderr when stdout is redirected
• f2c4a41: 8328481: Implement JEP 476: Module Import Declarations (Preview)
• 9347bb7: 8330247: C2: CTW fail with assert(adr_t->is_known_instance_field()) failed: instance required
• b20fa7b: 8329982: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found
• c1a1645: 8331655: ClassFile API ClassCastException with verbose output of certain class files
• 36c9607: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused
• ... and 8 more: https://git.openjdk.org/jdk/compare/58ef9e4805c0cc78935eb5a1c82ae10411d52e85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fc22ec90)

[egahlin]

/integrate

[openjdk]

Going to push as commit e8a2d56.
Since your change was applied there have been 18 commits pushed to the master branch:

• 9b0bb03: 8331285: Deprecate and obsolete OldSize
• 6c77641: 8331418: ZGC: generalize barrier liveness logic
• 15862a2: 8331708: jdk/internal/jline/RedirectedStdOut.java times-out on macosx-aarch64
• 4bbd972: 8305638: Renaming and small clean-ups around predicates
• f1509e0: 8330998: System.console() writes to stderr when stdout is redirected
• f2c4a41: 8328481: Implement JEP 476: Module Import Declarations (Preview)
• 9347bb7: 8330247: C2: CTW fail with assert(adr_t->is_known_instance_field()) failed: instance required
• b20fa7b: 8329982: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found
• c1a1645: 8331655: ClassFile API ClassCastException with verbose output of certain class files
• 36c9607: 8331591: sun.font.CharSequenceCodePointIterator is buggy and unused
• ... and 8 more: https://git.openjdk.org/jdk/compare/58ef9e4805c0cc78935eb5a1c82ae10411d52e85...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit e8a2d56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.