Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331715: Remove virtual specifiers in ContiguousSpace #19099

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented May 6, 2024

Trivial removing unused virtual and moving accessors together.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331715: Remove virtual specifiers in ContiguousSpace (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19099/head:pull/19099
$ git checkout pull/19099

Update a local copy of the PR:
$ git checkout pull/19099
$ git pull https://git.openjdk.org/jdk.git pull/19099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19099

View PR using the GUI difftool:
$ git pr show -t 19099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19099.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331715: Remove virtual specifiers in ContiguousSpace

Reviewed-by: gli, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 7f29904: 8330005: RandomGeneratorFactory.getDefault() throws exception when the runtime image only has java.base module
  • 2baacfc: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
  • 7b79426: 8278353: Provide Duke as default favicon in Simple Web Server
  • 466a21d: 8331863: DUIterator_Fast used before it is constructed
  • 8af606f: 8331334: com/sun/net/httpserver/HttpsParametersClientAuthTest.java fails in testServerNeedClientAuth(false)
  • b910833: 8331864: Update Public Suffix List to 1cbd6e7
  • f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
  • 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
  • 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
  • 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
  • ... and 18 more: https://git.openjdk.org/jdk/compare/4bbd972cbb114b99e856aa7904c0240049052b6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8331715 8331715: Remove virtual specifiers in ContiguousSpace May 6, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2024
@openjdk
Copy link

openjdk bot commented May 6, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 6, 2024
@mlbridge
Copy link

mlbridge bot commented May 6, 2024

Webrevs

Copy link
Member

@lgxbslgx lgxbslgx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 8, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2024

Going to push as commit 0e1dca7.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 7f29904: 8330005: RandomGeneratorFactory.getDefault() throws exception when the runtime image only has java.base module
  • 2baacfc: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
  • 7b79426: 8278353: Provide Duke as default favicon in Simple Web Server
  • 466a21d: 8331863: DUIterator_Fast used before it is constructed
  • 8af606f: 8331334: com/sun/net/httpserver/HttpsParametersClientAuthTest.java fails in testServerNeedClientAuth(false)
  • b910833: 8331864: Update Public Suffix List to 1cbd6e7
  • f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
  • 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
  • 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
  • 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
  • ... and 18 more: https://git.openjdk.org/jdk/compare/4bbd972cbb114b99e856aa7904c0240049052b6a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2024
@openjdk openjdk bot closed this May 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@albertnetymk Pushed as commit 0e1dca7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch May 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants