Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros #191

Closed
wants to merge 1 commit into from

Conversation

@robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Sep 15, 2020

Remove the KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros, replacing uses of KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_. Unlike KILL_COMPILE_ON_FATAL_, CHECK_AND_CLEAR_ ignores ThreadDeath exceptions, which compiler threads should not receive anyway.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/191/head:pull/191
$ git checkout pull/191

…cros

Remove the KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros, replacing uses
 of KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_. Unlike KILL_COMPILE_ON_FATAL_,
 CHECK_AND_CLEAR_ ignores ThreadDeath exceptions, which compiler threads should
 not receive anyway.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2020

👋 Welcome back robcasloz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 15, 2020

/summary
Remove the KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros, replacing uses
of KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_. Unlike KILL_COMPILE_ON_FATAL_,
CHECK_AND_CLEAR_ ignores ThreadDeath exceptions, which compiler threads should
not receive anyway.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@robcasloz Setting summary to:

Remove the KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros, replacing uses
of KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_. Unlike KILL_COMPILE_ON_FATAL_,
CHECK_AND_CLEAR_ ignores ThreadDeath exceptions, which compiler threads should
not receive anyway.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@robcasloz The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@robcasloz robcasloz marked this pull request as ready for review Sep 15, 2020
@openjdk openjdk bot added the rfr label Sep 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2020

Webrevs

Loading

Copy link

@iwanowww iwanowww left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@robcasloz This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8252966: CI: Remove KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros

Remove the KILL_COMPILE_ON_FATAL_ and KILL_COMPILE_ON_ANY macros, replacing uses
of KILL_COMPILE_ON_FATAL_ with CHECK_AND_CLEAR_. Unlike KILL_COMPILE_ON_FATAL_,
CHECK_AND_CLEAR_ ignores ThreadDeath exceptions, which compiler threads should
not receive anyway.

Reviewed-by: vlivanov, neliasso
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 16 commits pushed to the master branch:

  • fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
  • 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/9ea43a9213e560f5a2b9c762677e8ad94a44a1d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fbf4699d233ef31bf859ca76587b32b629c636ab.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @neliasso) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Sep 15, 2020
Copy link
Contributor

@neliasso neliasso left a comment

Looks good!

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 15, 2020

Thank you Vladimir and Nils!

Loading

@robcasloz
Copy link
Contributor Author

@robcasloz robcasloz commented Sep 15, 2020

/integrate

Loading

@openjdk openjdk bot added the sponsor label Sep 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2020

@robcasloz
Your change (at version f249446) is now ready to be sponsored by a Committer.

Loading

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 16, 2020

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@TobiHartmann @robcasloz Since your change was applied there have been 16 commits pushed to the master branch:

  • fbf4699: 8253040: Remove unused Matcher::regnum_to_fpu_offset()
  • 7c564e1: 8253146: C2: Purge unused MachCallNode::_arg_size field
  • 2caa20a: 8250668: Clean up method_oop names in adlc
  • 57f92d2: 8220483: Calendar.setTime(Date date) throws NPE with Date date = null
  • 65bfe09: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • fc36328: 8253034: Update symbol generation to accomodate Git as the SCM
  • 4020682: 8172366: Support SHA-3 based signatures
  • 46598c8: 8253177: outputStream not declared in markWord.hpp
  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/9ea43a9213e560f5a2b9c762677e8ad94a44a1d7...master

Your commit was automatically rebased without conflicts.

Pushed as commit efe3540.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants