8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB

[YaSuenag]

G1 heap summary (G1 Heap, summaries for each spaces) is shown on console even though I chosen "Heap Parameters" menu on HSDB. It should be shown on "Heap Parameters" window on HSDB.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB

Reviewers

• Chris Plummer (@plummercj - Reviewer) ⚠️ Review applies to 4d8d484
• Thomas Schatzl (@tschatzl - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1911/head:pull/1911
$ git checkout pull/1911

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following labels will be automatically applied to this pull request:

• hotspot-gc
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[YaSuenag]

/issue add JDK-8259009

[openjdk]

@YaSuenag The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[mlbridge]

Webrevs

• 02: Full - Incremental (6fa2204)
• 01: Full - Incremental (7fca843)
• 00: Full (4d8d484)

[YaSuenag]

PING: could you review it?

[plummercj]

Copyrights need updating. Otherwise looks good.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259009: G1 heap summary should be shown in "Heap Parameters" window on HSDB

Reviewed-by: cjplummer, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[YaSuenag]

@plummercj Thank you for the review! I updated copyright year in new commit.

[tschatzl]

I would prefer to make the order of parameters uniform in printG1HeapSummary(G1CollectedHeap g1h, PrintStream tty) { too. I.e. there does not seem to be a reason to have only this function have tty as second parameter.

[YaSuenag]

@tschatzl Thanks for the comment! I fixed it.

[YaSuenag]

/integrate

[openjdk]

@YaSuenag Since your change was applied there have been 8 commits pushed to the master branch:

• acbcde8: 8256111: Create implementation for NSAccessibilityStaticText protocol
• f928265: 8260009: InstanceKlass::has_as_permitted_subclass() fails if subclass was redefined
• 7ed8ba1: 8256814: WeakProcessorPhases may be redundant
• bfac3fb: 8260212: Shenandoah: resolve-only UpdateRefsMode is not used
• 58ceb25: 8259842: Remove Result cache from StringCoding
• d066f2b: 8260030: Improve stringStream buffer handling
• 1452280: 8164484: Unity, JTable cell editor, javax/swing/JComboBox/6559152/bug6559152.java
• a70acf2: 8259928: compiler/jvmci tests fail with -Xint

Your commit was automatically rebased without conflicts.

Pushed as commit 154e1d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.