8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator

[viktorklang-ora]

Removes SORTED if not also ORDERED for escape-hatch Stream::spliterator()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator (Bug - P4)

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19123/head:pull/19123
$ git checkout pull/19123

Update a local copy of the PR:
$ git checkout pull/19123
$ git pull https://git.openjdk.org/jdk.git pull/19123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19123

View PR using the GUI difftool:
$ git pr show -t 19123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19123.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator

Reviewed-by: psandoz, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

• 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
• 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
• 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
• 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
• 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
• 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• a2584a8: 8331714: Make OopMapCache installation lock-free
• df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
• 3b8227b: 8326836: Incorrect @since tags for ClassSignature methods
• f308e10: 8331400: AArch64: Sync aarch64_vector.ad with aarch64_vector_ad.m4
• ... and 92 more: https://git.openjdk.org/jdk/compare/cff841f1de41c911ec1b642b998c074e13e75554...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2f0bfbbf)

[viktorklang-ora]

Tagging @PaulSandoz for review :)

[viktorklang-ora]

/integrate

[openjdk]

Going to push as commit f12ed06.
Since your change was applied there have been 103 commits pushed to the master branch:

• 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
• 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
• 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
• 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
• 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
• 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
• 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• a2584a8: 8331714: Make OopMapCache installation lock-free
• df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
• 3b8227b: 8326836: Incorrect @since tags for ClassSignature methods
• ... and 93 more: https://git.openjdk.org/jdk/compare/cff841f1de41c911ec1b642b998c074e13e75554...master

Your commit was automatically rebased without conflicts.

[openjdk]

@viktorklang-ora Pushed as commit f12ed06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.