Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331864: Update Public Suffix List to 1cbd6e7 #19127

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented May 7, 2024

Update PSL to the latest upstream version.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331864: Update Public Suffix List to 1cbd6e7 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19127/head:pull/19127
$ git checkout pull/19127

Update a local copy of the PR:
$ git checkout pull/19127
$ git pull https://git.openjdk.org/jdk.git pull/19127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19127

View PR using the GUI difftool:
$ git pr show -t 19127

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19127.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331864: Update Public Suffix List to 1cbd6e7

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
  • 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
  • 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
  • 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
  • 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
  • 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
  • 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
  • 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
  • a2584a8: 8331714: Make OopMapCache installation lock-free
  • df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
  • ... and 15 more: https://git.openjdk.org/jdk/compare/9347bb7df845ee465c378c6f511ef8a6caea18ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@wangweij The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 7, 2024
@wangweij
Copy link
Contributor Author

wangweij commented May 7, 2024

/label remove core-libs

@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@wangweij
The core-libs label was successfully removed.

@wangweij wangweij marked this pull request as draft May 7, 2024 17:51
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 7, 2024
@wangweij wangweij marked this pull request as ready for review May 7, 2024 22:13
@openjdk openjdk bot added the rfr Pull request is ready for review label May 7, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 7, 2024
@wangweij
Copy link
Contributor Author

wangweij commented May 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 7, 2024

Going to push as commit b910833.
Since your change was applied there have been 25 commits pushed to the master branch:

  • f12ed06: 8048691: Spliterator.SORTED characteristics gets cleared for BaseStream.spliterator
  • 8d78e8c: 8319997: JFR: Reduce use of dynamic proxies
  • 524aaad: 8319957: PhaseOutput::code_size is unused and should be removed
  • 95d2f80: 8330016: Stress seed should be initialized for runtime stub compilation
  • 5746137: 8331771: ZGC: Remove OopMapCacheAlloc_lock ordering workaround
  • 02c95a6: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length
  • 02a799c: 8331695: Serial: DefNewGeneration:_promotion_failed used without being initialized
  • 23a72a1: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
  • a2584a8: 8331714: Make OopMapCache installation lock-free
  • df1ff05: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()
  • ... and 15 more: https://git.openjdk.org/jdk/compare/9347bb7df845ee465c378c6f511ef8a6caea18ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 7, 2024
@openjdk openjdk bot closed this May 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

@wangweij Pushed as commit b910833.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8331864 branch May 24, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants