8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

[alisenchung]

Opening closed dnd test
Test is green on all platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed (Bug - P4)

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to 8d63997e
• Damon Nguyen (@DamonGuy - Committer) ⚠️ Review applies to fb1d2e9b
• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to fb1d2e9b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19128/head:pull/19128
$ git checkout pull/19128

Update a local copy of the PR:
$ git checkout pull/19128
$ git pull https://git.openjdk.org/jdk.git pull/19128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19128

View PR using the GUI difftool:
$ git pr show -t 19128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19128.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

Reviewed-by: serb, dnguyen, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

• 5053b70: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
• 32c7681: 8332029: Provide access to initial value of stderr via JavaLangAccess
• f9a1d33: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
• b87a7e9: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
• 1dac34f: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP
• 5e8e8ef: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
• 1b476f5: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
• 1c5f150: 8331734: Atomic MemorySegment VarHandle operations fails for element layouts
• 65abf24: 8331866: Add warnings for locale data dependence
• d215bc4: 8332066: AArch64: Math test failures since JDK-8331558
• ... and 131 more: https://git.openjdk.org/jdk/compare/0a24daecebd90eb46a813923bb2d5672514197ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alisenchung The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (dc676f0a)
• 01: Full - Incremental (fb1d2e9b)
• 00: Full (8d63997e)

[DamonGuy]

LGTM. Just add a newline for separation after the test tags.

[DamonGuy]

Suggested change

	*/
	public final class MouseEventAfterStartDragTest implements AWTEventListener {
	*/
	public final class MouseEventAfterStartDragTest implements AWTEventListener {

[alisenchung]

i thought the standard was to have no newline between the test tags and the class declaration?

[DamonGuy]

I'm not aware of this. I've normally seen newlines after the test tags, and I use it in my tests without any comments. Not critical either way I suppose. Maybe others know more precisely? @TejeshR13 @kumarabhi006 maybe?

[kumarabhi006]

I use a newline after jtreg tags in my tests as well but I don't think it is as such mandatory.

[DamonGuy]

From the thread in the discussion Abhishek linked in our internal discussion, it looks like whatever we deem is neatest. But it looks like the big emphasis is on making it uniform. Sounds like most are using the newline.

[TejeshR13]

LGTM.

[prrace]

You are opening the test, but the bug ID is about the test failing.
Why specifically did the test fail before and what about this version fixes that ?

[alisenchung]

You are opening the test, but the bug ID is about the test failing. Why specifically did the test fail before and what about this version fixes that ?

The test needed some delays between mouse moves for stability. I accidentally deleted a delay when I moved the test but I've readded it now.

[alisenchung]

/integrate

[openjdk]

Going to push as commit 6f7ddbe.
Since your change was applied there have been 192 commits pushed to the master branch:

• fa3e94d: 8332393: Problemlist compiler/rangechecks/TestArrayAccessAboveRCAfterRCCastIIEliminated.java
• a33cb90: 8332098: Add missing @ since tags to jdk.jdi
• 910d77b: 8331953: ubsan: metaspaceShared.cpp:1305:57: runtime error: applying non-zero offset 12849152 to null pointer
• f9f8d0b: 8332101: Add an @since to StandardOperation:REMOVE in jdk.dynalink
• f398cd2: 8331575: C2: crash when ConvL2I is split thru phi at LongCountedLoop
• 96c5c3f: 8329998: Remove double initialization for parts of small TypeArrays in ZObjArrayAllocator
• ee4a9d3: 8321622: ClassFile.verify(byte[] bytes) throws unexpected ConstantPoolException, IAE
• ab8d7b0: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs
• fe8a2af: 8307778: com/sun/jdi/cds tests fail with jtreg's Virtual test thread factory
• 95f79c6: 8332253: Linux arm32 build fails after 8292591
• ... and 182 more: https://git.openjdk.org/jdk/compare/0a24daecebd90eb46a813923bb2d5672514197ce...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alisenchung Pushed as commit 6f7ddbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.