-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331189: Implementation of Scoped Values (Third Preview) #19136
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove compiler |
@AlanBateman |
@AlanBateman |
@AlanBateman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. That all looks reasonable enough, and gets us to the status quo ante + ScopedValue.CallableOp
, which is way better than what we have right now.
Webrevs
|
@@ -532,6 +490,24 @@ private void runWith(Snapshot newSnapshot, Runnable op) { | |||
} | |||
} | |||
|
|||
/** | |||
* An operation that returns a result and may throw an exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - should it be "or may throw an exception"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I like how the new functional interface makes the API seem smaller.
/integrate |
Going to push as commit 7071542.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit 7071542. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
JEP 481 proposes Scoped Values to continue to preview in JDK 23 with one change. The type of the operation parameter of the callWhere method is changed to a new functional interface to avoid having the API throw Exception. With that change, the getWhere (and the corresponding method on Carrier) are no longer needed. The functional interface is not proposed for j.u.function at this time.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19136/head:pull/19136
$ git checkout pull/19136
Update a local copy of the PR:
$ git checkout pull/19136
$ git pull https://git.openjdk.org/jdk.git pull/19136/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19136
View PR using the GUI difftool:
$ git pr show -t 19136
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19136.diff
Webrev
Link to Webrev Comment