8331189: Implementation of Scoped Values (Third Preview) #19136

AlanBateman · 2024-05-08T09:40:38Z

JEP 481 proposes Scoped Values to continue to preview in JDK 23 with one change. The type of the operation parameter of the callWhere method is changed to a new functional interface to avoid having the API throw Exception. With that change, the getWhere (and the corresponding method on Carrier) are no longer needed. The functional interface is not proposed for j.u.function at this time.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8331190 to be approved

Issues

JDK-8331189: Implementation of Scoped Values (Third Preview) (Enhancement - P4)
JDK-8331190: Implementation of Scoped Values (Third Preview) (CSR)

Reviewers

Andrew Haley (@theRealAph - Reviewer)
Jaikiran Pai (@jaikiran - Reviewer)
Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19136/head:pull/19136
$ git checkout pull/19136

Update a local copy of the PR:
$ git checkout pull/19136
$ git pull https://git.openjdk.org/jdk.git pull/19136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19136

View PR using the GUI difftool:
$ git pr show -t 19136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19136.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-05-08T09:41:19Z

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-05-08T09:42:51Z

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331189: Implementation of Scoped Values (Third Preview)

Reviewed-by: aph, jpai, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

4acafb8: 8333107: javac fails with an exception when processing broken lambda
921860d: 8333264: Remove unused resolve_sub_helper declaration after JDK-8322630
4a20691: 8331876: JFR: Move file read and write events to java.base
f608918: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull
1b04f64: 8216984: Deprecate for removal Socket constructors to create UDP sockets
3cff588: 8332826: Make hashCode methods in ArraysSupport friendlier
2b4a4b7: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
286cc16: 8327401: Some jtreg tests fail on Wayland without any tracking bug
579cf70: 8332597: Remove redundant methods from j.l.classfile.ClassReader API
57bfd0e: 8332065: Calling readLine(null...) or readPassword(null...) on System.console() hangs jshell
... and 7 more: https://git.openjdk.org/jdk/compare/43a2f17342af8f5bf1f5823df9fa0bf0bdfdfce2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-05-08T09:43:10Z

@AlanBateman The following labels will be automatically applied to this pull request:

client
compiler
core-libs
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

AlanBateman · 2024-05-08T09:44:24Z

/label remove compiler
/label remove client
/label remove security

openjdk · 2024-05-08T09:44:34Z

@AlanBateman
The compiler label was successfully removed.

openjdk · 2024-05-08T09:45:01Z

@AlanBateman
The client label was successfully removed.

openjdk · 2024-05-08T09:45:28Z

@AlanBateman
The security label was successfully removed.

src/java.base/share/classes/java/lang/ScopedValue.java

theRealAph

Thanks. That all looks reasonable enough, and gets us to the status quo ante + ScopedValue.CallableOp, which is way better than what we have right now.

mlbridge · 2024-05-21T08:31:10Z

Webrevs

01: Full - Incremental (b2166e66)
00: Full (744e8665)

jaikiran · 2024-05-21T15:15:18Z

src/java.base/share/classes/java/lang/ScopedValue.java

@@ -532,6 +490,24 @@ private void runWith(Snapshot newSnapshot, Runnable op) {
        }
    }

+    /**
+     * An operation that returns a result and may throw an exception.


Nit - should it be "or may throw an exception"?

jaikiran

The changes look OK to me.

mcimadamore

Changes look good. I like how the new functional interface makes the API seem smaller.

AlanBateman · 2024-05-30T15:41:14Z

/integrate

openjdk · 2024-05-30T15:41:57Z

Going to push as commit 7071542.
Since your change was applied there have been 17 commits pushed to the master branch:

4acafb8: 8333107: javac fails with an exception when processing broken lambda
921860d: 8333264: Remove unused resolve_sub_helper declaration after JDK-8322630
4a20691: 8331876: JFR: Move file read and write events to java.base
f608918: 8332614: Type-checked ConstantPool.entryByIndex and ClassReader.readEntryOrNull
1b04f64: 8216984: Deprecate for removal Socket constructors to create UDP sockets
3cff588: 8332826: Make hashCode methods in ArraysSupport friendlier
2b4a4b7: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
286cc16: 8327401: Some jtreg tests fail on Wayland without any tracking bug
579cf70: 8332597: Remove redundant methods from j.l.classfile.ClassReader API
57bfd0e: 8332065: Calling readLine(null...) or readPassword(null...) on System.console() hangs jshell
... and 7 more: https://git.openjdk.org/jdk/compare/43a2f17342af8f5bf1f5823df9fa0bf0bdfdfce2...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-05-30T15:42:02Z

@AlanBateman Pushed as commit 7071542.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Initial commit

e9e70da

openjdk bot added security security-dev@openjdk.org client client-libs-dev@openjdk.org core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels May 8, 2024

AlanBateman changed the title ~~Implementation of Scoped Values (Third Preview)~~ 8331189: Implementation of Scoped Values (Third Preview) May 8, 2024

openjdk bot added csr Pull request needs approved CSR before integration and removed compiler compiler-dev@openjdk.org labels May 8, 2024

openjdk bot removed the client client-libs-dev@openjdk.org label May 8, 2024

openjdk bot removed the security security-dev@openjdk.org label May 8, 2024

ExE-Boss reviewed May 9, 2024

View reviewed changes

src/java.base/share/classes/java/lang/ScopedValue.java Show resolved Hide resolved

AlanBateman added 4 commits May 15, 2024 10:00

Merge

7876ee1

Sync up from loom repo

611993a

Set JEP number

71573ba

Merge

6dc4f38

theRealAph approved these changes May 20, 2024

View reviewed changes

Merge

744e866

AlanBateman marked this pull request as ready for review May 21, 2024 08:27

openjdk bot added the rfr Pull request is ready for review label May 21, 2024

jaikiran reviewed May 21, 2024

View reviewed changes

jaikiran approved these changes May 21, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 21, 2024

openjdk bot removed the csr Pull request needs approved CSR before integration label May 21, 2024

Merge

b2166e6

mcimadamore approved these changes May 30, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label May 30, 2024

openjdk bot closed this May 30, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 30, 2024

graalvmbot mentioned this pull request Jun 10, 2024

[GR-54580] Update labsjdk to 23+26-jvmci-b01 oracle/graal#9078

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8331189: Implementation of Scoped Values (Third Preview) #19136

8331189: Implementation of Scoped Values (Third Preview) #19136

AlanBateman commented May 8, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented May 8, 2024

openjdk bot commented May 8, 2024 •

edited

Loading

openjdk bot commented May 8, 2024

AlanBateman commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

theRealAph left a comment

mlbridge bot commented May 21, 2024 •

edited

Loading

jaikiran May 21, 2024

jaikiran left a comment

mcimadamore left a comment

AlanBateman commented May 30, 2024

openjdk bot commented May 30, 2024

openjdk bot commented May 30, 2024

8331189: Implementation of Scoped Values (Third Preview) #19136

8331189: Implementation of Scoped Values (Third Preview) #19136

Conversation

AlanBateman commented May 8, 2024 • edited by openjdk bot Loading

Progress

Issues

Reviewers

Reviewing

Webrev

bridgekeeper bot commented May 8, 2024

openjdk bot commented May 8, 2024 • edited Loading

openjdk bot commented May 8, 2024

AlanBateman commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

openjdk bot commented May 8, 2024

theRealAph left a comment

Choose a reason for hiding this comment

mlbridge bot commented May 21, 2024 • edited Loading

Webrevs

jaikiran May 21, 2024

Choose a reason for hiding this comment

jaikiran left a comment

Choose a reason for hiding this comment

mcimadamore left a comment

Choose a reason for hiding this comment

AlanBateman commented May 30, 2024

openjdk bot commented May 30, 2024

openjdk bot commented May 30, 2024

AlanBateman commented May 8, 2024 •

edited by openjdk bot

Loading

openjdk bot commented May 8, 2024 •

edited

Loading

mlbridge bot commented May 21, 2024 •

edited

Loading