Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4926314: Optimize Reader.read(CharBuffer) #1915

Closed
wants to merge 16 commits into from
Closed

4926314: Optimize Reader.read(CharBuffer) #1915

wants to merge 16 commits into from

Commits on Dec 31, 2020

  1. 4926314: Optimize Reader.read(CharBuffer) 

    Implement three optimiztations for Reader.read(CharBuffer)

Add a code path for heap buffers in Reader#read to use the backing array instead of allocating a new one.

Change the code path for direct buffers in Reader#read to limit the intermediate allocation to TRANSFER_BUFFER_SIZE.

Implement InputStreamReader#read(CharBuffer) and delegate to StreamDecoder.

Implement StreamDecoder#read(CharBuffer) and avoid buffer allocation.
    @marschall
    marschall committed Dec 31, 2020
    Copy the full SHA
    967b314 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Fix off-heap code path 

    The off-heap code path was missing a buffer.put
    @marschall
    marschall committed Jan 4, 2021
    Copy the full SHA
    a88cd93 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Update copyright years

    @marschall
    marschall committed Jan 5, 2021
    Copy the full SHA
    8d40558 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Add unit tests 

    - add unit test for Reader#read(CharBuffer)
- add unit test for InputStreamReader#reader(CharBuffer)
- test with both on-heap and off-heap buffers
    @marschall
    marschall committed Jan 9, 2021
    Copy the full SHA
    d247b63 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Limit amount read to avoid BufferOverflowException 

    - limit the amount read
- add tests
    @marschall
    marschall committed Jan 26, 2021
    Copy the full SHA
    a8531c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Implement CharArrayReader#read(CharBuffer)

    @marschall
    marschall committed Feb 9, 2021
    Copy the full SHA
    f2390ec View commit details
    Browse the repository at this point in the history

  2. Revert StreamDecoder changes

    @marschall
    marschall committed Feb 9, 2021
    Copy the full SHA
    2915e13 View commit details
    Browse the repository at this point in the history

  3. Implement review comment

    @marschall
    marschall committed Feb 9, 2021
    Copy the full SHA
    275fd48 View commit details
    Browse the repository at this point in the history

  4. Update copyright year

    @marschall
    marschall committed Feb 9, 2021
    Copy the full SHA
    08948f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Share work buffer between #skip and #read

    @marschall
    marschall committed Feb 12, 2021
    Copy the full SHA
    8875c5d View commit details
    Browse the repository at this point in the history

  2. Replace c-style array declarations

    @marschall
    marschall committed Feb 12, 2021
    Copy the full SHA
    fc29f3e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Revert off-heap code path

    @marschall
    marschall committed Mar 13, 2021
    Copy the full SHA
    6886954 View commit details
    Browse the repository at this point in the history

  2. Clean up unit tests

    @marschall
    marschall committed Mar 13, 2021
    Copy the full SHA
    6dac38d View commit details
    Browse the repository at this point in the history

  3. Fix bug in CharArrayReader and add unit test

    @marschall
    marschall committed Mar 13, 2021
    Copy the full SHA
    5fa832b View commit details
    Browse the repository at this point in the history

  4. Merge master

    @marschall
    marschall committed Mar 13, 2021
    Copy the full SHA
    c4c859e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. Fix typos in comments

    @marschall
    marschall committed Apr 25, 2021
    Copy the full SHA
    bbc4274 View commit details
    Browse the repository at this point in the history