Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes #19163

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented May 10, 2024

This is a request to limit the memory used by the test, otherwise it could run "forever" on huge heaps.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19163/head:pull/19163
$ git checkout pull/19163

Update a local copy of the PR:
$ git checkout pull/19163
$ git pull https://git.openjdk.org/jdk.git pull/19163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19163

View PR using the GUI difftool:
$ git pr show -t 19163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19163.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Reviewed-by: phh, shade, egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 162 new commits pushed to the master branch:

  • f8a3e4e: 8328998: Encoding support for Intel APX extended general-purpose registers
  • ddd73b4: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
  • 0a9d1f8: 8332749: Broken link in MemorySegment.Scope.html
  • c9a7b97: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
  • 7fd9d6c: 8332340: Add JavacBench as a test case for CDS
  • 417d174: 8331348: Some incremental builds deposit files in the make directory
  • 303ac9f: 8332671: Logging for pretouching thread stacks shows wrong memory range
  • 90758f6: 8332808: Always set java.io.tmpdir to a suitable value in the build
  • e19a421: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
  • 2581935: 8332528: Generate code in SwitchBootstraps.generateTypeSwitch that require fewer adaptations
  • ... and 152 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@mrserb The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label May 10, 2024
@mrserb mrserb marked this pull request as ready for review May 10, 2024 17:40
@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2024
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @egahlin, would you like to ack as well?

@shipilev
Copy link
Member

One minor nit: This bug does not seem to be caused by Shenandoah, it is just well triggered by it. @sendaoYan had a sighting with Parallel, see the comment in the bug. Maybe we should drop Shenandoah: from synopsis before we integrate the fix.

@mrserb mrserb changed the title 8316328: Shenandoah: jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes 8316328: jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes May 23, 2024
@mrserb mrserb changed the title 8316328: jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes May 23, 2024
@mrserb
Copy link
Member Author

mrserb commented May 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2024

Going to push as commit 9b1d6d6.
Since your change was applied there have been 162 commits pushed to the master branch:

  • f8a3e4e: 8328998: Encoding support for Intel APX extended general-purpose registers
  • ddd73b4: 8332082: Shenandoah: Use consistent tests to determine when pre-write barrier is active
  • 0a9d1f8: 8332749: Broken link in MemorySegment.Scope.html
  • c9a7b97: 8332829: [BACKOUT] C2: crash in compiled code because of dependency on removed range check CastIIs
  • 7fd9d6c: 8332340: Add JavacBench as a test case for CDS
  • 417d174: 8331348: Some incremental builds deposit files in the make directory
  • 303ac9f: 8332671: Logging for pretouching thread stacks shows wrong memory range
  • 90758f6: 8332808: Always set java.io.tmpdir to a suitable value in the build
  • e19a421: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
  • 2581935: 8332528: Generate code in SwitchBootstraps.generateTypeSwitch that require fewer adaptations
  • ... and 152 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2024
@openjdk openjdk bot closed this May 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@mrserb Pushed as commit 9b1d6d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8316328 branch May 23, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants